From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kPk5Ix3yIV+veQAA0tVLHw (envelope-from ) for ; Wed, 29 Jul 2020 22:03:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wPFRHx3yIV91eAAA1q6Kng (envelope-from ) for ; Wed, 29 Jul 2020 22:03:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D3BDD94051F for ; Wed, 29 Jul 2020 22:03:08 +0000 (UTC) Received: from localhost ([::1]:36456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0uAE-0004vl-Mr for larch@yhetil.org; Wed, 29 Jul 2020 18:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0uAA-0004u6-Jq for guix-patches@gnu.org; Wed, 29 Jul 2020 18:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k0uAA-00082i-8v for guix-patches@gnu.org; Wed, 29 Jul 2020 18:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k0uAA-0000eO-5T for guix-patches@gnu.org; Wed, 29 Jul 2020 18:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42306] [PATCH] gnu: Add nfs4-acl-tools Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Jul 2020 22:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42306 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 42306@debbugs.gnu.org Received: via spool by 42306-submit@debbugs.gnu.org id=B42306.15960601222428 (code B ref 42306); Wed, 29 Jul 2020 22:03:02 +0000 Received: (at 42306) by debbugs.gnu.org; 29 Jul 2020 22:02:02 +0000 Received: from localhost ([127.0.0.1]:33858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0u9B-0000cw-Vh for submit@debbugs.gnu.org; Wed, 29 Jul 2020 18:02:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0u98-0000cY-Ec for 42306@debbugs.gnu.org; Wed, 29 Jul 2020 18:02:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54627) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0u92-0007y6-OC; Wed, 29 Jul 2020 18:01:52 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:51726 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k0u91-0007Gq-9B; Wed, 29 Jul 2020 18:01:51 -0400 From: Marius Bakke In-Reply-To: <20200727071139.GB3225@zpidnp36> References: <20200710092101.GA22947@zpidnp36> <87blk3vcyn.fsf@gnu.org> <20200727071139.GB3225@zpidnp36> Date: Thu, 30 Jul 2020 00:01:28 +0200 Message-ID: <87k0ymq8uf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: MNzab2pHlgoX --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Lars-Dominik Braun writes: > Hey Marius, > >> Sorry for the late reply... > no problem. > >> The patch mostly LGTM, but no longer applies. Can you rebase it on >> current master? Meanwhile, a few comments: > Sure, see attached patch, which (hopefully) also improves the description. Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to UTF-8 in order to make it apply. Applied with the following changes: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=diff diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm index 128afc52c2..a6409765ff 100644 --- a/gnu/packages/acl.scm +++ b/gnu/packages/acl.scm @@ -27,7 +27,6 @@ #:use-module (gnu packages attr) #:use-module (gnu packages autotools) #:use-module (gnu packages base) - #:use-module (gnu packages bash) #:use-module (gnu packages gettext) #:use-module (gnu packages perl) #:use-module (guix packages) @@ -116,14 +115,13 @@ #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-bin-sh - (lambda* (#:key inputs native-inputs #:allow-other-keys) + (lambda _ (substitute* "include/buildmacros" - (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh"))) + (("/bin/sh") (which "sh"))) #t))))) (native-inputs `(("automake" ,automake) ("autoconf" ,autoconf) - ("bash-minimal" ,bash-minimal) ("libtool" ,libtool))) (inputs `(("attr" ,attr))) @@ -134,4 +132,3 @@ POSIX equivalents @command{getfacl} and @command{setfacl}. They fetch and manipulate access control lists for files and directories on NFSv4 mounts.") (license bsd-3))) - --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ...however I also decided to move it to (gnu packages nfs). > I noticed linting fails with a pattern matching error, because git:// pro= tocol > URI=E2=80=99s are not supported. The second patch fixes it, but I=E2=80= =99m not sure that=E2=80=99s a > =E2=80=9Cproper=E2=80=9D solution. Me neither and I don't feel like jumping on that one right away. :-) It seems we already have a number of git:// URLs around so it would be good to fix it, can you submit the second patch to a separate issue? Thanks! --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8h8bgACgkQoqBt8qM6 VPouAgf9F38mmXe+AMpLcKeitAgwBdIqlYk/0sOa+qKDJZhfwmPwjK2VAw4Hl+Gp odoJgz6SzVStp78pKfWSmcSMCb3GETIV/0rG2xm4upG3c4L+l4t33opFERWvy+nY lqdbhFyCVSZ4JAaElx1R1VbXLUXEamKoYpQgkIFR4H77oiDrrb16b23zzcbFmyLI 6ONprl2q8KVhwDIv76a2mDmPzu5ZfXASOMr9wQ8SdgkV+kHczBMMiCDKtQZyO7/k tNAc2GmCqjCQmd0a5nCYOBnuQWr4an7ktEt2ienH7FcTGuR36nHUZJ6uiBFhso2w 8ItbQB2yezTtEbcc25OqiqpPTPdwqQ== =ywmL -----END PGP SIGNATURE----- --==-=-=--