From: Marius Bakke <marius@gnu.org>
To: Lars-Dominik Braun <ldb@leibniz-psychology.org>, 42306@debbugs.gnu.org
Subject: [bug#42306] [PATCH] gnu: Add nfs4-acl-tools
Date: Sat, 25 Jul 2020 17:20:00 +0200 [thread overview]
Message-ID: <87blk3vcyn.fsf@gnu.org> (raw)
In-Reply-To: <20200710092101.GA22947@zpidnp36>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
Hello!
Sorry for the late reply...
The patch mostly LGTM, but no longer applies. Can you rebase it on
current master? Meanwhile, a few comments:
Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:
> * gnu/packages/acl.scm (nfs4-acl-tools): New variable.
> * gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.
> * gnu/local.mk: Add it.
[...]
> + (synopsis "This package contains commandline ACL utilities for the Linux
> +NFSv4 client")
Just "Command line ACL utilities for NFS"
> + (description "Provides the commandline utilities nfs4_setfacl and
> +nfs4_getfacl, which are similar to their POSIX equivalents.")
Descriptions OTOH should be complete sentences, something like:
"This package provides the command line utilities
@command{nfs4_setfacl} and @command{nfs4_getfacl} [...]".
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-07-25 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 9:21 [bug#42306] [PATCH] gnu: Add nfs4-acl-tools Lars-Dominik Braun
2020-07-25 15:20 ` Marius Bakke [this message]
2020-07-27 7:11 ` Lars-Dominik Braun
2020-07-29 22:01 ` Marius Bakke
2020-07-30 7:17 ` Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blk3vcyn.fsf@gnu.org \
--to=marius@gnu.org \
--cc=42306@debbugs.gnu.org \
--cc=ldb@leibniz-psychology.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).