unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
@ 2022-04-14 13:50 Paul A. Patience
  2022-04-14 14:35 ` bug#54937: " Guillaume Le Vaillant
  0 siblings, 1 reply; 4+ messages in thread
From: Paul A. Patience @ 2022-04-14 13:50 UTC (permalink / raw)
  To: 54937; +Cc: Paul A. Patience

* gnu/packages/lisp-xyz.scm (cl-numpy-file-format,
ecl-numpy-file-format, sbcl-numpy-file-format): New variables.
---
 gnu/packages/lisp-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 29b3a10d98..28b25edd24 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5151,6 +5151,38 @@ (define-public cl-find-port
 (define-public ecl-find-port
   (sbcl-package->ecl-package sbcl-find-port))

+(define-public sbcl-numpy-file-format
+  (let ((commit "e97aef6c592a412fdd1afa9a5f09d0b1ce134510")
+        (revision "1"))
+    (package
+      (name "sbcl-numpy-file-format")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/marcoheisig/numpy-file-format")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0j7jjcf6k3anvgpm4nf81g6gbhff44v0v9rai7kwm2bm3abzsjfd"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-ieee-floats sbcl-trivial-features))
+      (home-page "https://github.com/marcoheisig/numpy-file-format")
+      (synopsis "Read and write NumPy .npy and .npz files")
+      (description
+       "The NUMPY-FILE-FORMAT library is a Common Lisp library for reading and
+writing NumPy @file{.npy} and @file{.npz} files.")
+      (license license:expat))))
+
+(define-public cl-numpy-file-format
+  (sbcl-package->cl-source-package sbcl-numpy-file-format))
+
+(define-public ecl-numpy-file-format
+  (sbcl-package->ecl-package sbcl-numpy-file-format))
+
 (define-public sbcl-py4cl
   (let ((commit "4c8a2b0814fd311f978964f825ce012290f60136")
         (revision "1"))
--
2.35.1






^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#54937: [PATCH] gnu: Add cl-numpy-file-format.
  2022-04-14 13:50 [bug#54937] [PATCH] gnu: Add cl-numpy-file-format Paul A. Patience
@ 2022-04-14 14:35 ` Guillaume Le Vaillant
  2022-04-14 19:05   ` [bug#54937] " Paul A. Patience
  0 siblings, 1 reply; 4+ messages in thread
From: Guillaume Le Vaillant @ 2022-04-14 14:35 UTC (permalink / raw)
  To: Paul A. Patience; +Cc: 54937-done

[-- Attachment #1: Type: text/plain, Size: 66 bytes --]

Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
  2022-04-14 14:35 ` bug#54937: " Guillaume Le Vaillant
@ 2022-04-14 19:05   ` Paul A. Patience
  2022-04-14 19:09     ` Guillaume Le Vaillant
  0 siblings, 1 reply; 4+ messages in thread
From: Paul A. Patience @ 2022-04-14 19:05 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: 54937-done

On Thursday, April 14th, 2022 at 10:35, Guillaume Le Vaillant <glv@posteo.net> wrote:
> Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
> Thanks.

Should

    (file-name (git-file-name "cl-numpy-file-format" version))

not be

    (file-name (git-file-name "numpy-file-format" version))

instead?

Best regards,
Paul





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
  2022-04-14 19:05   ` [bug#54937] " Paul A. Patience
@ 2022-04-14 19:09     ` Guillaume Le Vaillant
  0 siblings, 0 replies; 4+ messages in thread
From: Guillaume Le Vaillant @ 2022-04-14 19:09 UTC (permalink / raw)
  To: Paul A. Patience; +Cc: 54937

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

"Paul A. Patience" <paul@apatience.com> skribis:

> On Thursday, April 14th, 2022 at 10:35, Guillaume Le Vaillant <glv@posteo.net> wrote:
>> Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
>> Thanks.
>
> Should
>
>     (file-name (git-file-name "cl-numpy-file-format" version))
>
> not be
>
>     (file-name (git-file-name "numpy-file-format" version))
>
> instead?
>
> Best regards,
> Paul

Previously, all CL packages using git-fetch were using
'(git-file-name name version)' in the 'source' field, and therefore the
sources were named "sbcl-something", which is a little weird as these
sources are also used for the "cl-*" and "ecl-*" packages that are
derived from the "sbcl-*" package definitions. The sources are not
specific to sbcl.
This is why when updating a CL package I use
'(git-file-name "cl-something" version)' instead. This way the naming
scheme for CL sources is similar to the others, like Python sources
fetched from git named "python-something", the R sources named
"r-something", etc.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-14 19:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 13:50 [bug#54937] [PATCH] gnu: Add cl-numpy-file-format Paul A. Patience
2022-04-14 14:35 ` bug#54937: " Guillaume Le Vaillant
2022-04-14 19:05   ` [bug#54937] " Paul A. Patience
2022-04-14 19:09     ` Guillaume Le Vaillant

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).