unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: "Paul A. Patience" <paul@apatience.com>
Cc: 54937@debbugs.gnu.org
Subject: [bug#54937] [PATCH] gnu: Add cl-numpy-file-format.
Date: Thu, 14 Apr 2022 19:09:44 +0000	[thread overview]
Message-ID: <877d7rbgum.fsf@kitej> (raw)
In-Reply-To: <yYvsJk_vCFEFZhz1_6_Zos-tV3IuEfFQeoQfhPY32N1-KYR8IHQXpvvkQ0ocMmqUKZM9XDPEo0lvv-HQlOlzsWN6Y-GEgpf4nUPBYL9aNMI=@apatience.com>

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

"Paul A. Patience" <paul@apatience.com> skribis:

> On Thursday, April 14th, 2022 at 10:35, Guillaume Le Vaillant <glv@posteo.net> wrote:
>> Patch pushed as 0ddca9d682013f10b7e0137878ab68363d929167.
>> Thanks.
>
> Should
>
>     (file-name (git-file-name "cl-numpy-file-format" version))
>
> not be
>
>     (file-name (git-file-name "numpy-file-format" version))
>
> instead?
>
> Best regards,
> Paul

Previously, all CL packages using git-fetch were using
'(git-file-name name version)' in the 'source' field, and therefore the
sources were named "sbcl-something", which is a little weird as these
sources are also used for the "cl-*" and "ecl-*" packages that are
derived from the "sbcl-*" package definitions. The sources are not
specific to sbcl.
This is why when updating a CL package I use
'(git-file-name "cl-something" version)' instead. This way the naming
scheme for CL sources is similar to the others, like Python sources
fetched from git named "python-something", the R sources named
"r-something", etc.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-04-14 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 13:50 [bug#54937] [PATCH] gnu: Add cl-numpy-file-format Paul A. Patience
2022-04-14 14:35 ` bug#54937: " Guillaume Le Vaillant
2022-04-14 19:05   ` [bug#54937] " Paul A. Patience
2022-04-14 19:09     ` Guillaume Le Vaillant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d7rbgum.fsf@kitej \
    --to=glv@posteo.net \
    --cc=54937@debbugs.gnu.org \
    --cc=paul@apatience.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).