unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#68204] [PATCH] gnu: Add emacs-ox-tufte.
@ 2024-01-02  7:36 Suhail via Guix-patches via
  2024-01-02 14:22 ` Nicolas Goaziou via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Suhail via Guix-patches via @ 2024-01-02  7:36 UTC (permalink / raw)
  To: 68204

* gnu/packages/emacs-xyz.scm (emacs-ox-tufte): Add at 3.0.3

Change-Id: Iaaff4b08eddb8f38b39f003e70821ace6c937c86
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2a24f4a106..1ecba18b1f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -136,6 +136,7 @@
 ;;; Copyright © 2023 Camilo Q.S. (Distopico) <distopico@riseup.net>
 ;;; Copyright © 2023 Thanos Apollo <public@thanosapollo.com>
 ;;; Copyright © 2023 Ian Eure <ian@retrospec.tv>
+;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33180,6 +33181,29 @@ (define-public emacs-ox-reveal
 simple but powerful Org contents.")
       (license license:gpl3+))))
 
+(define-public emacs-ox-tufte
+  (package
+    (name "emacs-ox-tufte")
+    (version "3.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://stable.melpa.org/packages/ox-tufte-"
+                           version ".tar"))
+       (sha256
+        (base32 "0bl4c8lv3z9r0kdf70fg3bkrm90yz15xbs5hzq8z5gk97iyvjvmx"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-org))
+    (home-page "https://github.com/ox-tufte/ox-tufte")
+    (synopsis "Tufte HTML org-mode export backend")
+    (description
+     "This is an export backend for Org-mode that exports buffers to HTML that is
+compatible with Tufte CSS - <https://edwardtufte.github.io/tufte-css/>.  The
+design goal is to \"minimally\" change the HTML structure as generated by `ox-html
+(with additional CSS as needed) to get behaviour that is equivalent to Tufte
+CSS.")
+    (license license:gpl3+)))
+
 (define-public emacs-ox-rss
   ;; XXX: Upstream provides no version nor tags whatsoever.
   (let ((commit "83dc898fa5493925b01716e5dd495d5e07c3d41a")

base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
-- 
2.43.0






^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#68204] [PATCH] gnu: Add emacs-ox-tufte.
  2024-01-02  7:36 [bug#68204] [PATCH] gnu: Add emacs-ox-tufte Suhail via Guix-patches via
@ 2024-01-02 14:22 ` Nicolas Goaziou via Guix-patches via
  2024-01-03  2:58 ` Suhail via Guix-patches via
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-01-02 14:22 UTC (permalink / raw)
  To: 68204; +Cc: suhail

Hello,

Suhail via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ox-tufte): Add at 3.0.3

Thanks. Some comments follow.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://stable.melpa.org/packages/ox-tufte-"
> +                           version ".tar"))

MELPA Stable is not considered as desirable upstream source. I suggest
to use GitHub instead.

> +       (sha256
> +        (base32 "0bl4c8lv3z9r0kdf70fg3bkrm90yz15xbs5hzq8z5gk97iyvjvmx"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-org))
> +    (home-page "https://github.com/ox-tufte/ox-tufte")
> +    (synopsis "Tufte HTML org-mode export backend")

Nitpick: Org mode

> +    (description
> +     "This is an export backend for Org-mode that exports buffers to HTML that is

Nitpick: Org mode

> +compatible with Tufte CSS - <https://edwardtufte.github.io/tufte-css/>.  The

Please use @url{...} instead.

> +design goal is to \"minimally\" change the HTML structure as generated by `ox-html

@emph{minimally} but I have the feeling that you can simply drop the
last sentence of the description.

> +(with additional CSS as needed) to get behaviour that is equivalent to Tufte
> +CSS.")
> +    (license license:gpl3+)))

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou






^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#68204] [PATCH] gnu: Add emacs-ox-tufte.
  2024-01-02  7:36 [bug#68204] [PATCH] gnu: Add emacs-ox-tufte Suhail via Guix-patches via
  2024-01-02 14:22 ` Nicolas Goaziou via Guix-patches via
@ 2024-01-03  2:58 ` Suhail via Guix-patches via
  2024-01-03  3:09 ` [bug#68204] [PATCH v2] " Suhail via Guix-patches via
  2024-01-17  4:26 ` Suhail via Guix-patches via
  3 siblings, 0 replies; 6+ messages in thread
From: Suhail via Guix-patches via @ 2024-01-03  2:58 UTC (permalink / raw)
  To: 68204; +Cc: suhail, mail

Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:

> Thanks. Some comments follow.

Thank you for the review.  All comments made sense; I'll send a revised
patch shortly.

-- 
Suhail

This email is not an offer capable of acceptance, does not evidence an
intention to enter into an agreement, has no operative effect until a
definitive agreement is signed in writing by both parties, and that no
party should act in reliance on the email or any representations of the
sender until a definitive agreement is signed in writing by both
parties.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#68204] [PATCH v2] gnu: Add emacs-ox-tufte.
  2024-01-02  7:36 [bug#68204] [PATCH] gnu: Add emacs-ox-tufte Suhail via Guix-patches via
  2024-01-02 14:22 ` Nicolas Goaziou via Guix-patches via
  2024-01-03  2:58 ` Suhail via Guix-patches via
@ 2024-01-03  3:09 ` Suhail via Guix-patches via
  2024-01-17  4:26 ` Suhail via Guix-patches via
  3 siblings, 0 replies; 6+ messages in thread
From: Suhail via Guix-patches via @ 2024-01-03  3:09 UTC (permalink / raw)
  To: 68204

* gnu/packages/emacs-xyz.scm (emacs-ox-tufte): New variable.

Change-Id: Iaaff4b08eddb8f38b39f003e70821ace6c937c86
---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2a24f4a106..1916bf82e5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -136,6 +136,7 @@
 ;;; Copyright © 2023 Camilo Q.S. (Distopico) <distopico@riseup.net>
 ;;; Copyright © 2023 Thanos Apollo <public@thanosapollo.com>
 ;;; Copyright © 2023 Ian Eure <ian@retrospec.tv>
+;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33180,6 +33181,29 @@ (define-public emacs-ox-reveal
 simple but powerful Org contents.")
       (license license:gpl3+))))
 
+(define-public emacs-ox-tufte
+  (package
+    (name "emacs-ox-tufte")
+    (version "3.0.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ox-tufte/ox-tufte")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "14i1pliifj5p0i1bgsdgph32ilj7snrh8gnhk59f1f4ngh3kw3zg"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-org))
+    (home-page "https://github.com/ox-tufte/ox-tufte")
+    (synopsis "Tufte HTML Org mode export backend")
+    (description
+     "This is an export backend for Org mode that exports buffers to HTML that
+is compatible with Tufte
+CSS (@url{https://edwardtufte.github.io/tufte-css/}).")
+    (license license:gpl3+)))
+
 (define-public emacs-ox-rss
   ;; XXX: Upstream provides no version nor tags whatsoever.
   (let ((commit "83dc898fa5493925b01716e5dd495d5e07c3d41a")

base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
-- 
2.43.0






^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#68204] [PATCH v2] gnu: Add emacs-ox-tufte.
  2024-01-02  7:36 [bug#68204] [PATCH] gnu: Add emacs-ox-tufte Suhail via Guix-patches via
                   ` (2 preceding siblings ...)
  2024-01-03  3:09 ` [bug#68204] [PATCH v2] " Suhail via Guix-patches via
@ 2024-01-17  4:26 ` Suhail via Guix-patches via
  2024-01-21 23:29   ` bug#68204: " Nicolas Goaziou via Guix-patches via
  3 siblings, 1 reply; 6+ messages in thread
From: Suhail via Guix-patches via @ 2024-01-17  4:26 UTC (permalink / raw)
  To: 68204


* gnu/packages/emacs-xyz.scm (emacs-ox-tufte): New variable.

Change-Id: Iaaff4b08eddb8f38b39f003e70821ace6c937c86
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2a24f4a106..090429b229 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -136,6 +136,7 @@
 ;;; Copyright © 2023 Camilo Q.S. (Distopico) <distopico@riseup.net>
 ;;; Copyright © 2023 Thanos Apollo <public@thanosapollo.com>
 ;;; Copyright © 2023 Ian Eure <ian@retrospec.tv>
+;;; Copyright © 2024 Suhail Singh <suhail@bayesians.ca>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33180,6 +33181,30 @@ (define-public emacs-ox-reveal
 simple but powerful Org contents.")
       (license license:gpl3+))))
 
+(define-public emacs-ox-tufte
+  (package
+    (name "emacs-ox-tufte")
+    (version "4.0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ox-tufte/ox-tufte")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1v8jr1k8wfpzwry073rrgkxfpwylxmk7xqabxzp49z40rc7hp26s"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-org))
+    (arguments '(#:include (cons "^src/" %default-include)))
+    (home-page "https://github.com/ox-tufte/ox-tufte")
+    (synopsis "Tufte HTML Org mode export backend")
+    (description
+     "This is an export backend for Org mode that exports buffers to HTML that
+is compatible with Tufte
+CSS (@url{https://edwardtufte.github.io/tufte-css/}).")
+    (license license:gpl3+)))
+
 (define-public emacs-ox-rss
   ;; XXX: Upstream provides no version nor tags whatsoever.
   (let ((commit "83dc898fa5493925b01716e5dd495d5e07c3d41a")

base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
-- 
2.43.0






^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#68204: [PATCH v2] gnu: Add emacs-ox-tufte.
  2024-01-17  4:26 ` Suhail via Guix-patches via
@ 2024-01-21 23:29   ` Nicolas Goaziou via Guix-patches via
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-01-21 23:29 UTC (permalink / raw)
  To: Suhail via Guix-patches via; +Cc: 68204-done, Suhail

Hello,

Suhail via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ox-tufte): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou






^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-01-21 23:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-02  7:36 [bug#68204] [PATCH] gnu: Add emacs-ox-tufte Suhail via Guix-patches via
2024-01-02 14:22 ` Nicolas Goaziou via Guix-patches via
2024-01-03  2:58 ` Suhail via Guix-patches via
2024-01-03  3:09 ` [bug#68204] [PATCH v2] " Suhail via Guix-patches via
2024-01-17  4:26 ` Suhail via Guix-patches via
2024-01-21 23:29   ` bug#68204: " Nicolas Goaziou via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).