unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: 68204@debbugs.gnu.org
Cc: suhail@bayesians.ca
Subject: [bug#68204] [PATCH] gnu: Add emacs-ox-tufte.
Date: Tue, 02 Jan 2024 15:22:57 +0100	[thread overview]
Message-ID: <87le97lsqm.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <d4a94f1cc08844866f42e3703b9632db35552b33.1704180757.git.suhail@bayesians.ca> (Suhail via Guix-patches via's message of "Tue, 02 Jan 2024 07:36:05 +0000")

Hello,

Suhail via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ox-tufte): Add at 3.0.3

Thanks. Some comments follow.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://stable.melpa.org/packages/ox-tufte-"
> +                           version ".tar"))

MELPA Stable is not considered as desirable upstream source. I suggest
to use GitHub instead.

> +       (sha256
> +        (base32 "0bl4c8lv3z9r0kdf70fg3bkrm90yz15xbs5hzq8z5gk97iyvjvmx"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-org))
> +    (home-page "https://github.com/ox-tufte/ox-tufte")
> +    (synopsis "Tufte HTML org-mode export backend")

Nitpick: Org mode

> +    (description
> +     "This is an export backend for Org-mode that exports buffers to HTML that is

Nitpick: Org mode

> +compatible with Tufte CSS - <https://edwardtufte.github.io/tufte-css/>.  The

Please use @url{...} instead.

> +design goal is to \"minimally\" change the HTML structure as generated by `ox-html

@emph{minimally} but I have the feeling that you can simply drop the
last sentence of the description.

> +(with additional CSS as needed) to get behaviour that is equivalent to Tufte
> +CSS.")
> +    (license license:gpl3+)))

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou






  reply	other threads:[~2024-01-02 14:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02  7:36 [bug#68204] [PATCH] gnu: Add emacs-ox-tufte Suhail via Guix-patches via
2024-01-02 14:22 ` Nicolas Goaziou via Guix-patches via [this message]
2024-01-03  2:58 ` Suhail via Guix-patches via
2024-01-03  3:09 ` [bug#68204] [PATCH v2] " Suhail via Guix-patches via
2024-01-17  4:26 ` Suhail via Guix-patches via
2024-01-21 23:29   ` bug#68204: " Nicolas Goaziou via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le97lsqm.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=68204@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=suhail@bayesians.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).