From: Dave Love <fx@gnu.org>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: 27905@debbugs.gnu.org
Subject: [bug#27905] changes for openmpi
Date: Mon, 11 Sep 2017 21:24:05 +0100 [thread overview]
Message-ID: <87ingpj862.fsf@albion.it.manchester.ac.uk> (raw)
In-Reply-To: <877exaqydo.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Thu, 07 Sep 2017 17:14:43 +0100")
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
I wrote:
>> So to me that means we can apply the patch below and be done with it.
>> Fine with you?
>
> No, I now think it shouldn't be changed, since the valgrind integration
> is supposed not to impose a significant speed penalty, and I can remove
> valgrind from the closure simply. I'll send a new patch later.
Here it is, eventually, which gets rid of a lot from the closure.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-openmpi-Remove-valgrind-from-closure.patch --]
[-- Type: text/x-diff, Size: 2234 bytes --]
From 6b47b2ce671bfbdab3c5f4f2546f02bcfee66d68 Mon Sep 17 00:00:00 2001
From: Dave Love <fx@gnu.org>
Date: Mon, 4 Sep 2017 18:04:21 +0100
Subject: [PATCH 2/2] gnu openmpi: Remove valgrind from closure.
* mpi.scm (openmpi)[arguments]: Elide romio config info to avoid valgrind
path.
---
gnu/packages/mpi.scm | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
index 76154a055..04f9d7ebe 100644
--- a/gnu/packages/mpi.scm
+++ b/gnu/packages/mpi.scm
@@ -146,16 +146,21 @@ bind processes, and much more.")
(assoc-ref %build-inputs "hwloc")))
#:phases (modify-phases %standard-phases
(add-before 'build 'remove-absolute
- ;; Remove compiler absolute file names (OPAL_FC_ABSOLUTE
- ;; etc.) to reduce the closure size. See
- ;; <https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00388.html>
- ;; and
- ;; <https://www.mail-archive.com/users@lists.open-mpi.org//msg31397.html>.
(lambda _
+ ;; Remove compiler absolute file names (OPAL_FC_ABSOLUTE
+ ;; etc.) to reduce the closure size. See
+ ;; <https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00388.html>
+ ;; and
+ ;; <https://www.mail-archive.com/users@lists.open-mpi.org//msg31397.html>.
(substitute* '("orte/tools/orte-info/param.c"
"oshmem/tools/oshmem_info/param.c"
"ompi/tools/ompi_info/param.c")
(("_ABSOLUTE") ""))
+ ;; Avoid valgrind (which pulls in gdb etc.).
+ (substitute*
+ '("./ompi/mca/io/romio/src/io_romio_component.c")
+ (("MCA_io_romio_COMPLETE_CONFIGURE_FLAGS")
+ "\"[elided to reduce closure]\""))
#t))
(add-before 'build 'scrub-timestamps ;reproducibility
(lambda _
--
2.11.0
next prev parent reply other threads:[~2017-09-11 20:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 12:54 [bug#27905] changes for openmpi Dave Love
2017-08-21 15:12 ` Ludovic Courtès
2017-08-23 13:00 ` Dave Love
2017-08-31 7:58 ` Ludovic Courtès
2017-09-01 11:24 ` Dave Love
2017-09-01 11:06 ` Dave Love
2017-09-04 15:10 ` Ludovic Courtès
2017-09-07 16:14 ` Dave Love
2017-09-11 20:24 ` Dave Love [this message]
2017-09-12 7:00 ` bug#27905: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ingpj862.fsf@albion.it.manchester.ac.uk \
--to=fx@gnu.org \
--cc=27905@debbugs.gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).