From: Dave Love <fx@gnu.org>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: 27905@debbugs.gnu.org
Subject: [bug#27905] changes for openmpi
Date: Thu, 07 Sep 2017 17:14:43 +0100 [thread overview]
Message-ID: <877exaqydo.fsf@albion.it.manchester.ac.uk> (raw)
In-Reply-To: <873782xzxb.fsf@inria.fr> ("Ludovic \=\?iso-8859-1\?Q\?Court\=E8s\?\= \=\?iso-8859-1\?Q\?\=22's\?\= message of "Mon, 4 Sep 2017 17:10:24 +0200")
Ludovic Courtès <ludovic.courtes@inria.fr> writes:
>>> Also, I assume that this is functionally equivalent to Open MPI’s
>>> built-in Valgrind support, is it?
>>
>> This is probably moot. It isn't entirely equivalent but, more
>> importantly, the builtin support apparently doesn't have the performance
>> hit which was documented; I haven't checked experimentally. See this
>> thread, though not all my questions were answered:
>> <https://www.mail-archive.com/users@lists.open-mpi.org//msg31459.html>.
>>
>> The wrapper library may still be relevant for mpich-y MPIs, if they get
>> used -- I don't know.
>
> OK.
>
> So to me that means we can apply the patch below and be done with it.
> Fine with you?
No, I now think it shouldn't be changed, since the valgrind integration
is supposed not to impose a significant speed penalty, and I can remove
valgrind from the closure simply. I'll send a new patch later.
> Thanks,
> Ludo’.
>
>
> diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
> index 93157e269..ded9d4fda 100644
> --- a/gnu/packages/mpi.scm
> +++ b/gnu/packages/mpi.scm
> @@ -36,8 +36,7 @@
> #:use-module (gnu packages xml)
> #:use-module (gnu packages perl)
> #:use-module (gnu packages ncurses)
> - #:use-module (gnu packages pkg-config)
> - #:use-module (gnu packages valgrind))
> + #:use-module (gnu packages pkg-config))
>
> (define-public hwloc
> (package
> @@ -126,8 +125,7 @@ bind processes, and much more.")
> `(("hwloc" ,hwloc "lib")
> ("gfortran" ,gfortran)
> ("libfabric" ,libfabric)
> - ("rdma-core" ,rdma-core)
> - ("valgrind" ,valgrind)))
> + ("rdma-core" ,rdma-core)))
> (native-inputs
> `(("pkg-config" ,pkg-config)
> ("perl" ,perl)))
> @@ -142,8 +140,6 @@ bind processes, and much more.")
> ;; it reduces the closure size considerably.
> "--disable-vt"
>
> - ,(string-append "--with-valgrind="
> - (assoc-ref %build-inputs "valgrind"))
> ,(string-append "--with-hwloc="
> (assoc-ref %build-inputs "hwloc")))
> #:phases (modify-phases %standard-phases
next prev parent reply other threads:[~2017-09-07 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 12:54 [bug#27905] changes for openmpi Dave Love
2017-08-21 15:12 ` Ludovic Courtès
2017-08-23 13:00 ` Dave Love
2017-08-31 7:58 ` Ludovic Courtès
2017-09-01 11:24 ` Dave Love
2017-09-01 11:06 ` Dave Love
2017-09-04 15:10 ` Ludovic Courtès
2017-09-07 16:14 ` Dave Love [this message]
2017-09-11 20:24 ` Dave Love
2017-09-12 7:00 ` bug#27905: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877exaqydo.fsf@albion.it.manchester.ac.uk \
--to=fx@gnu.org \
--cc=27905@debbugs.gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).