From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drVGU-0005sv-31 for guix-patches@gnu.org; Mon, 11 Sep 2017 16:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drVGP-0000oG-TD for guix-patches@gnu.org; Mon, 11 Sep 2017 16:25:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53685) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drVGP-0000o7-Oa for guix-patches@gnu.org; Mon, 11 Sep 2017 16:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drVGP-00052I-J6 for guix-patches@gnu.org; Mon, 11 Sep 2017 16:25:01 -0400 Subject: [bug#27905] changes for openmpi Resent-Message-ID: From: Dave Love References: <87zibja1of.fsf@i-ulialbion.it.manchester.ac.uk> <87h8x1t0op.fsf@gnu.org> <87d17aznix.fsf@albion.it.manchester.ac.uk> <873782xzxb.fsf@inria.fr> <877exaqydo.fsf@albion.it.manchester.ac.uk> Date: Mon, 11 Sep 2017 21:24:05 +0100 In-Reply-To: <877exaqydo.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Thu, 07 Sep 2017 17:14:43 +0100") Message-ID: <87ingpj862.fsf@albion.it.manchester.ac.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ARC-IRS-Mace-Avian-Talent" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27905@debbugs.gnu.org --ARC-IRS-Mace-Avian-Talent Content-Type: text/plain I wrote: >> So to me that means we can apply the patch below and be done with it. >> Fine with you? > > No, I now think it shouldn't be changed, since the valgrind integration > is supposed not to impose a significant speed penalty, and I can remove > valgrind from the closure simply. I'll send a new patch later. Here it is, eventually, which gets rid of a lot from the closure. --ARC-IRS-Mace-Avian-Talent Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-gnu-openmpi-Remove-valgrind-from-closure.patch >From 6b47b2ce671bfbdab3c5f4f2546f02bcfee66d68 Mon Sep 17 00:00:00 2001 From: Dave Love Date: Mon, 4 Sep 2017 18:04:21 +0100 Subject: [PATCH 2/2] gnu openmpi: Remove valgrind from closure. * mpi.scm (openmpi)[arguments]: Elide romio config info to avoid valgrind path. --- gnu/packages/mpi.scm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm index 76154a055..04f9d7ebe 100644 --- a/gnu/packages/mpi.scm +++ b/gnu/packages/mpi.scm @@ -146,16 +146,21 @@ bind processes, and much more.") (assoc-ref %build-inputs "hwloc"))) #:phases (modify-phases %standard-phases (add-before 'build 'remove-absolute - ;; Remove compiler absolute file names (OPAL_FC_ABSOLUTE - ;; etc.) to reduce the closure size. See - ;; - ;; and - ;; . (lambda _ + ;; Remove compiler absolute file names (OPAL_FC_ABSOLUTE + ;; etc.) to reduce the closure size. See + ;; + ;; and + ;; . (substitute* '("orte/tools/orte-info/param.c" "oshmem/tools/oshmem_info/param.c" "ompi/tools/ompi_info/param.c") (("_ABSOLUTE") "")) + ;; Avoid valgrind (which pulls in gdb etc.). + (substitute* + '("./ompi/mca/io/romio/src/io_romio_component.c") + (("MCA_io_romio_COMPLETE_CONFIGURE_FLAGS") + "\"[elided to reduce closure]\"")) #t)) (add-before 'build 'scrub-timestamps ;reproducibility (lambda _ -- 2.11.0 --ARC-IRS-Mace-Avian-Talent--