[bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.

[ludo@gnu.org (Ludovic Courtès)]

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Mon, 08 Jan 2018 10:26:54 +0100
> ludo@gnu.org (Ludovic Courtès) wrote:

[...]

>> It’d feel more idiomatic to me if, instead, we had an
>> ‘operating-system-boot-kernel-arguments’ procedure that takes an OS and
>> returns (list --root --system …).  Then it’d be up to the caller to
>> append that to what ‘operating-system-kernel-arguments’ returns.
>
> Yeah, but looking at it some more, it doesn't really need an OS.  It needs the system derivation (and root device).

Since <operating-system> has a “gexp compiler”, you can write:

  #~(string-append "--system=" #$os)

where ‘os’ is an <operating-system>.  It automatically computes its
derivation.  Thus, no need to explicitly call
‘operating-system-derivation’ and pass “system.drv” arguments around.

So we’d just need a slight adjustment to ‘bootable-kernel-arguments’ (so
that it takes the root device from the given OS object) and then rename
it to ‘operating-system-kernel-arguments’.

How does that sound?

Ludo’.