From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYpeb-0007hJ-DX
	for guix-patches@gnu.org; Tue, 09 Jan 2018 03:53:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYpeY-0002IO-DM
	for guix-patches@gnu.org; Tue, 09 Jan 2018 03:53:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33404)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eYpeY-0002IH-9m
	for guix-patches@gnu.org; Tue, 09 Jan 2018 03:53:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYpeY-0008VU-2v
	for guix-patches@gnu.org; Tue, 09 Jan 2018 03:53:02 -0500
Subject: [bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.
Resent-Message-ID: <handler.29932.B29932.151548794332655@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180101132200.26157-1-dannym@scratchpost.org>
	<878td8k8f5.fsf@gnu.org> <20180109092133.3f740ba3@scratchpost.org>
Date: Tue, 09 Jan 2018 09:52:17 +0100
In-Reply-To: <20180109092133.3f740ba3@scratchpost.org> (Danny Milosavljevic's
	message of "Tue, 9 Jan 2018 09:21:33 +0100")
Message-ID: <87incbxvlq.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 29932@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Mon, 08 Jan 2018 10:26:54 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

[...]

>> It=E2=80=99d feel more idiomatic to me if, instead, we had an
>> =E2=80=98operating-system-boot-kernel-arguments=E2=80=99 procedure that =
takes an OS and
>> returns (list --root --system =E2=80=A6).  Then it=E2=80=99d be up to th=
e caller to
>> append that to what =E2=80=98operating-system-kernel-arguments=E2=80=99 =
returns.
>
> Yeah, but looking at it some more, it doesn't really need an OS.  It need=
s the system derivation (and root device).

Since <operating-system> has a =E2=80=9Cgexp compiler=E2=80=9D, you can wri=
te:

  #~(string-append "--system=3D" #$os)

where =E2=80=98os=E2=80=99 is an <operating-system>.  It automatically comp=
utes its
derivation.  Thus, no need to explicitly call
=E2=80=98operating-system-derivation=E2=80=99 and pass =E2=80=9Csystem.drv=
=E2=80=9D arguments around.

So we=E2=80=99d just need a slight adjustment to =E2=80=98bootable-kernel-a=
rguments=E2=80=99 (so
that it takes the root device from the given OS object) and then rename
it to =E2=80=98operating-system-kernel-arguments=E2=80=99.

How does that sound?

Ludo=E2=80=99.