[bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.

[ludo@gnu.org (Ludovic Courtès)]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi Ludo,
>
>>   #~(string-append "--system=" #$os)
>> 
>> where ‘os’ is an <operating-system>.  It automatically computes its
>> derivation.  Thus, no need to explicitly call
>> ‘operating-system-derivation’ and pass “system.drv” arguments around.
>
> Ah!  Good to know.
>
>> So we’d just need a slight adjustment to ‘bootable-kernel-arguments’ (so
>> that it takes the root device from the given OS object) and then rename
>> it to ‘operating-system-kernel-arguments’.
>
> bootable-kernel-arguments is also used by the "parameters" file serializer.

Good point, so probably we need to keep it as-is internally.  For user
consumption though, we can expose ‘operating-system-kernel-arguments’
(or whatever we call it.)

> Also, the user that is modifying a <operating-system> instance (for example marionette-operating-system adding "panic=1") would erronously use operating-system-kernel-arguments in order to get the previous instance's arguments, resulting in the "--root", "--load" etc being prepended twice, no?
>
> The user might want to pass some kernel arguments which have nothing to do with Guix (which <operating-system>'s "kernel-arguments" is for) and then GuixSD needs some extra arguments to be able to boot the actual system (which can be found entirely automatically - nice!).

Oh wait, now I realize that ‘operating-system-kernel-arguments’ is
already taken.  :-)

So another name suggestion would be:
‘operating-system-essential-kernel-arguments’.  Thoughts?

Sorry for the confusion!

Ludo’.