* [bug#40668] [PATCH] installer: Fix backtrace display.
@ 2020-04-16 17:33 Mathieu Othacehe
2020-04-17 21:07 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2020-04-16 17:33 UTC (permalink / raw)
To: 40668; +Cc: Mathieu Othacehe
The 'syslog' macro cannot be resolved in the pre-unwind-handler
context. Failed to resolve 'syslog' in this context resulted in the swallowing
of all installation errors.
Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.
* gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
in the pre-unwind-handler.
---
Hello,
Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
this means that every error happening in the 1.1.0 release will result in an
installer restart, without any error information reporting.
Thanks,
Mathieu
gnu/installer.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gnu/installer.scm b/gnu/installer.scm
index 1051ee1e5f..eba8a7d428 100644
--- a/gnu/installer.scm
+++ b/gnu/installer.scm
@@ -436,8 +436,9 @@ selected keymap."
#f)))
(const #f)
(lambda (key . args)
- (syslog "crashing due to uncaught exception: ~s ~s~%"
- key args)
+ ((@@ (gnu installer utils) syslog)
+ "crashing due to uncaught exception: ~s ~s~%"
+ key args)
(let ((error-file "/tmp/last-installer-error"))
(call-with-output-file error-file
(lambda (port)
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#40668] [PATCH] installer: Fix backtrace display.
2020-04-16 17:33 [bug#40668] [PATCH] installer: Fix backtrace display Mathieu Othacehe
@ 2020-04-17 21:07 ` Ludovic Courtès
2020-04-18 15:46 ` bug#40668: " Mathieu Othacehe
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2020-04-17 21:07 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 40668
Hello,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> The 'syslog' macro cannot be resolved in the pre-unwind-handler
> context. Failed to resolve 'syslog' in this context resulted in the swallowing
> of all installation errors.
>
> Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.
>
> * gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
> in the pre-unwind-handler.
[...]
> Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
> this means that every error happening in the 1.1.0 release will result in an
> installer restart, without any error information reporting.
Oh, that’s terrible. :-/ Sorry about that.
> - (syslog "crashing due to uncaught exception: ~s ~s~%"
> - key args)
> + ((@@ (gnu installer utils) syslog)
> + "crashing due to uncaught exception: ~s ~s~%"
> + key args)
Please add (gnu installer utils) to the list of use-modules.
‘@@’ should only be used in extreme situations.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#40668: [PATCH] installer: Fix backtrace display.
2020-04-17 21:07 ` Ludovic Courtès
@ 2020-04-18 15:46 ` Mathieu Othacehe
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Othacehe @ 2020-04-18 15:46 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 40668-done
Hey,
> Please add (gnu installer utils) to the list of use-modules.
> ‘@@’ should only be used in extreme situations.
Fixed and pushed!
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-18 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 17:33 [bug#40668] [PATCH] installer: Fix backtrace display Mathieu Othacehe
2020-04-17 21:07 ` Ludovic Courtès
2020-04-18 15:46 ` bug#40668: " Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).