unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40668@debbugs.gnu.org
Subject: [bug#40668] [PATCH] installer: Fix backtrace display.
Date: Fri, 17 Apr 2020 23:07:05 +0200	[thread overview]
Message-ID: <87imhxakjq.fsf@gnu.org> (raw)
In-Reply-To: <20200416173354.11807-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Thu, 16 Apr 2020 19:33:54 +0200")

Hello,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> The 'syslog' macro cannot be resolved in the pre-unwind-handler
> context. Failed to resolve 'syslog' in this context resulted in the swallowing
> of all installation errors.
>
> Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd.
>
> * gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro
> in the pre-unwind-handler.

[...]

> Since the commit 5c04b00c, error reporting in the installer is broken. Sadly
> this means that every error happening in the 1.1.0 release will result in an
> installer restart, without any error information reporting. 

Oh, that’s terrible.  :-/  Sorry about that.

> -                  (syslog "crashing due to uncaught exception: ~s ~s~%"
> -                          key args)
> +                  ((@@ (gnu installer utils) syslog)
> +                   "crashing due to uncaught exception: ~s ~s~%"
> +                   key args)

Please add (gnu installer utils) to the list of use-modules.
‘@@’ should only be used in extreme situations.

Thanks,
Ludo’.

  reply	other threads:[~2020-04-17 21:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 17:33 [bug#40668] [PATCH] installer: Fix backtrace display Mathieu Othacehe
2020-04-17 21:07 ` Ludovic Courtès [this message]
2020-04-18 15:46   ` bug#40668: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imhxakjq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40668@debbugs.gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).