From: Christopher Baines <mail@cbaines.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 41023-done@debbugs.gnu.org
Subject: bug#41023: [PATCH core-updates] gnu: behave: Fix build with Python 3.8.
Date: Sat, 02 May 2020 15:58:04 +0100 [thread overview]
Message-ID: <87imhemlj7.fsf@cbaines.net> (raw)
In-Reply-To: <878sia4jvx.fsf@devup.no>
[-- Attachment #1: Type: text/plain, Size: 2177 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Christopher Baines <mail@cbaines.net> writes:
>
>> Add a patch based on an upstream commit [1].
>>
>> 1: c000c88eb5239b87f299c85e83b349b0ef387ae7
>>
>> * gnu/packages/patches/behave-skip-a-couple-of-tests.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>> * gnu/packages/check.scm (behave)[source]: Use the patch.
>
> [...]
>
>> diff --git a/gnu/packages/patches/behave-skip-a-couple-of-tests.patch b/gnu/packages/patches/behave-skip-a-couple-of-tests.patch
>> new file mode 100644
>> index 0000000000..4985f34425
>> --- /dev/null
>> +++ b/gnu/packages/patches/behave-skip-a-couple-of-tests.patch
>> @@ -0,0 +1,476 @@
>> +From c000c88eb5239b87f299c85e83b349b0ef387ae7 Mon Sep 17 00:00:00 2001
>> +From: jenisys <jenisys@users.noreply.github.com>
>> +Date: Sun, 7 Jul 2019 12:43:19 +0200
>> +Subject: [PATCH] FIX: python3.8 regressions on CI server
>> +
>> +Issues w/ python3.8:
>> +* Traceback: Line numbers of step functions differ (+1)
>> +* JUnit XML: Attribute ordering of XML element differs (in output)
>> +---
>> + behave.ini | 3 +-
>> + features/environment.py | 14 ++++++
>> + features/step.duplicated_step.feature | 20 ++++----
>> + issue.features/environment.py | 38 ++++++++++++---
>> + issue.features/issue0330.feature | 64 ++++++++++++++++++++++++
>> + issue.features/issue0446.feature | 70 +++++++++++++++++++++++++++
>> + issue.features/issue0457.feature | 49 +++++++++++++++++++
>> + tox.ini | 2 +-
>> + 8 files changed, 242 insertions(+), 18 deletions(-)
>
> Same comment as the previous review. These statistics are not useful,
> but describing the issue and linking to the upstream resources is.
I've tweaked the top of the patch file now.
> Due to the sheer size of the patch, consider using an origin instead of
> copying it into the Guix repository.
Unfortunately the patch isn't exactly the same as the upstream commit,
as I had to tweak it in one place to get it to apply.
I've gone ahead and pushed this as
a8cb1e72ef351330d1521833c1b270dcc0da593f now.
Thanks for taking a look :)
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
prev parent reply other threads:[~2020-05-02 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 11:31 [bug#41023] [PATCH core-updates] gnu: behave: Fix build with Python 3.8 Christopher Baines
2020-05-02 12:10 ` Marius Bakke
2020-05-02 14:58 ` Christopher Baines [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imhemlj7.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=41023-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).