unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Christopher Baines <mail@cbaines.net>, 41023@debbugs.gnu.org
Subject: [bug#41023] [PATCH core-updates] gnu: behave: Fix build with Python 3.8.
Date: Sat, 02 May 2020 14:10:58 +0200	[thread overview]
Message-ID: <878sia4jvx.fsf@devup.no> (raw)
In-Reply-To: <20200502113154.4487-1-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> Add a patch based on an upstream commit [1].
>
> 1: c000c88eb5239b87f299c85e83b349b0ef387ae7
>
> * gnu/packages/patches/behave-skip-a-couple-of-tests.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/check.scm (behave)[source]: Use the patch.

[...]

> diff --git a/gnu/packages/patches/behave-skip-a-couple-of-tests.patch b/gnu/packages/patches/behave-skip-a-couple-of-tests.patch
> new file mode 100644
> index 0000000000..4985f34425
> --- /dev/null
> +++ b/gnu/packages/patches/behave-skip-a-couple-of-tests.patch
> @@ -0,0 +1,476 @@
> +From c000c88eb5239b87f299c85e83b349b0ef387ae7 Mon Sep 17 00:00:00 2001
> +From: jenisys <jenisys@users.noreply.github.com>
> +Date: Sun, 7 Jul 2019 12:43:19 +0200
> +Subject: [PATCH] FIX: python3.8 regressions on CI server
> +
> +Issues w/ python3.8:
> +* Traceback: Line numbers of step functions differ (+1)
> +* JUnit XML: Attribute ordering of XML element differs (in output)
> +---
> + behave.ini                            |  3 +-
> + features/environment.py               | 14 ++++++
> + features/step.duplicated_step.feature | 20 ++++----
> + issue.features/environment.py         | 38 ++++++++++++---
> + issue.features/issue0330.feature      | 64 ++++++++++++++++++++++++
> + issue.features/issue0446.feature      | 70 +++++++++++++++++++++++++++
> + issue.features/issue0457.feature      | 49 +++++++++++++++++++
> + tox.ini                               |  2 +-
> + 8 files changed, 242 insertions(+), 18 deletions(-)

Same comment as the previous review.  These statistics are not useful,
but describing the issue and linking to the upstream resources is.

Due to the sheer size of the patch, consider using an origin instead of
copying it into the Guix repository.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-05-02 12:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 11:31 [bug#41023] [PATCH core-updates] gnu: behave: Fix build with Python 3.8 Christopher Baines
2020-05-02 12:10 ` Marius Bakke [this message]
2020-05-02 14:58   ` bug#41023: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sia4jvx.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=41023@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).