Marius Bakke writes: > Christopher Baines writes: > >> Add a patch based on an upstream commit [1]. >> >> 1: c000c88eb5239b87f299c85e83b349b0ef387ae7 >> >> * gnu/packages/patches/behave-skip-a-couple-of-tests.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. >> * gnu/packages/check.scm (behave)[source]: Use the patch. > > [...] > >> diff --git a/gnu/packages/patches/behave-skip-a-couple-of-tests.patch b/gnu/packages/patches/behave-skip-a-couple-of-tests.patch >> new file mode 100644 >> index 0000000000..4985f34425 >> --- /dev/null >> +++ b/gnu/packages/patches/behave-skip-a-couple-of-tests.patch >> @@ -0,0 +1,476 @@ >> +From c000c88eb5239b87f299c85e83b349b0ef387ae7 Mon Sep 17 00:00:00 2001 >> +From: jenisys >> +Date: Sun, 7 Jul 2019 12:43:19 +0200 >> +Subject: [PATCH] FIX: python3.8 regressions on CI server >> + >> +Issues w/ python3.8: >> +* Traceback: Line numbers of step functions differ (+1) >> +* JUnit XML: Attribute ordering of XML element differs (in output) >> +--- >> + behave.ini | 3 +- >> + features/environment.py | 14 ++++++ >> + features/step.duplicated_step.feature | 20 ++++---- >> + issue.features/environment.py | 38 ++++++++++++--- >> + issue.features/issue0330.feature | 64 ++++++++++++++++++++++++ >> + issue.features/issue0446.feature | 70 +++++++++++++++++++++++++++ >> + issue.features/issue0457.feature | 49 +++++++++++++++++++ >> + tox.ini | 2 +- >> + 8 files changed, 242 insertions(+), 18 deletions(-) > > Same comment as the previous review. These statistics are not useful, > but describing the issue and linking to the upstream resources is. I've tweaked the top of the patch file now. > Due to the sheer size of the patch, consider using an origin instead of > copying it into the Guix repository. Unfortunately the patch isn't exactly the same as the upstream commit, as I had to tweak it in one place to get it to apply. I've gone ahead and pushed this as a8cb1e72ef351330d1521833c1b270dcc0da593f now. Thanks for taking a look :) Chris