* [bug#41088] [PATCH] gnu: Add gnome-shell-extension-clipboard-indicator.
@ 2020-05-04 22:30 Jack Hill
2020-05-04 22:40 ` [bug#41088] [PATCH v2] " Jack Hill
2020-05-05 20:12 ` [bug#41088] [PATCH v3] " Jack Hill
0 siblings, 2 replies; 6+ messages in thread
From: Jack Hill @ 2020-05-04 22:30 UTC (permalink / raw)
To: 41088
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):
New variable.
---
gnu/packages/gnome-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 625248a25a..ee5176d22a 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -148,6 +148,48 @@ GNOME Shell.")
(home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
(license license:gpl2+)))
+(define-public gnome-shell-extension-clipboard-indicator
+ (package
+ (name "gnome-shell-extension-clipboard-indicator")
+ (version "34")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url (string-append "https://github.com/Tudmotu/"
+ "gnome-shell-extension-clipboard-indicator.git"))
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0i00psc1ky70zljd14jzr627y7nd8xwnwrh4xpajl1f6djabh12s"))
+ (modules '((guix build utils)))
+ (snippet
+ '(begin (delete-file "schemas/gschemas.compiled")
+ (for-each delete-file (find-files "locale" "\\.mo$"))
+ #t))))
+ (build-system copy-build-system)
+ (arguments
+ '(#:install-plan
+ '(("." "share/gnome-shell/extensions/clipboard-indicator@tudmotu.com"
+ #:include-regexp ("\\.css$" "\\.compiled$" "\\.js(on)?$" "\\.mo$" "\\.xml$")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'compile-schemas
+ (lambda _
+ (with-directory-excursion "schemas"
+ (invoke "glib-compile-schemas" "."))
+ #t))
+ (add-before 'install 'compile-locales
+ (lambda _ (invoke "./compile-locales.sh"))))))
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("glib:bin" ,glib "bin"))) ; for glib-compile-schemas
+ (home-page "https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator")
+ (synopsis "Clipboard manager extension for GNOME Shell")
+ (description "Clipboard Indicator is a clipboard manager for GNOME Shell
+that caches clipboard history.")
+ (license license:expat)))
+
(define-public gnome-shell-extension-topicons-redux
(package
(name "gnome-shell-extension-topicons-redux")
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#41088] [PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator.
2020-05-04 22:30 [bug#41088] [PATCH] gnu: Add gnome-shell-extension-clipboard-indicator Jack Hill
@ 2020-05-04 22:40 ` Jack Hill
2020-05-05 18:06 ` Marius Bakke
2020-05-05 20:12 ` [bug#41088] [PATCH v3] " Jack Hill
1 sibling, 1 reply; 6+ messages in thread
From: Jack Hill @ 2020-05-04 22:40 UTC (permalink / raw)
To: 41088
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):
New variable.
---
New in this version: Now all phases return #t
gnu/packages/gnome-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 625248a25a..26de92c2c9 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -148,6 +148,49 @@ GNOME Shell.")
(home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
(license license:gpl2+)))
+(define-public gnome-shell-extension-clipboard-indicator
+ (package
+ (name "gnome-shell-extension-clipboard-indicator")
+ (version "34")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url (string-append "https://github.com/Tudmotu/"
+ "gnome-shell-extension-clipboard-indicator.git"))
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0i00psc1ky70zljd14jzr627y7nd8xwnwrh4xpajl1f6djabh12s"))
+ (modules '((guix build utils)))
+ (snippet
+ '(begin (delete-file "schemas/gschemas.compiled")
+ (for-each delete-file (find-files "locale" "\\.mo$"))
+ #t))))
+ (build-system copy-build-system)
+ (arguments
+ '(#:install-plan
+ '(("." "share/gnome-shell/extensions/clipboard-indicator@tudmotu.com"
+ #:include-regexp ("\\.css$" "\\.compiled$" "\\.js(on)?$" "\\.mo$" "\\.xml$")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'compile-schemas
+ (lambda _
+ (with-directory-excursion "schemas"
+ (invoke "glib-compile-schemas" "."))
+ #t))
+ (add-before 'install 'compile-locales
+ (lambda _ (invoke "./compile-locales.sh")
+ #t)))))
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("glib:bin" ,glib "bin"))) ; for glib-compile-schemas
+ (home-page "https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator")
+ (synopsis "Clipboard manager extension for GNOME Shell")
+ (description "Clipboard Indicator is a clipboard manager for GNOME Shell
+that caches clipboard history.")
+ (license license:expat)))
+
(define-public gnome-shell-extension-topicons-redux
(package
(name "gnome-shell-extension-topicons-redux")
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#41088] [PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator.
2020-05-04 22:40 ` [bug#41088] [PATCH v2] " Jack Hill
@ 2020-05-05 18:06 ` Marius Bakke
2020-05-05 20:11 ` Jack Hill
0 siblings, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2020-05-05 18:06 UTC (permalink / raw)
To: Jack Hill, 41088
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
Jack Hill <jackhill@jackhill.us> writes:
> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):
> New variable.
Thanks!
[...]
> + (snippet
> + '(begin (delete-file "schemas/gschemas.compiled")
> + (for-each delete-file (find-files "locale" "\\.mo$"))
> + #t))))
Can you add a comment about why this is necessary?
Otherwise LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#41088] [PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator.
2020-05-05 18:06 ` Marius Bakke
@ 2020-05-05 20:11 ` Jack Hill
0 siblings, 0 replies; 6+ messages in thread
From: Jack Hill @ 2020-05-05 20:11 UTC (permalink / raw)
To: Marius Bakke; +Cc: 41088
On Tue, 5 May 2020, Marius Bakke wrote:
> Jack Hill <jackhill@jackhill.us> writes:
>
>> + (snippet
>> + '(begin (delete-file "schemas/gschemas.compiled")
>> + (for-each delete-file (find-files "locale" "\\.mo$"))
>> + #t))))
>
> Can you add a comment about why this is necessary?
I've added a commend and will send the updated patch shortly. However, I
may have been wrong to remove these files as part of the snippet. I did it
because the removed files are not source form, but instead can be
generated from source during the package build. I believe that upstream
includes them in the code repository because it is common for people to
install GNOME Shell extensions by directly cloning the repo in their home
directories.
> Otherwise LGTM.
Thanks for the review.
Best,
Jack
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#41088] [PATCH v3] gnu: Add gnome-shell-extension-clipboard-indicator.
2020-05-04 22:30 [bug#41088] [PATCH] gnu: Add gnome-shell-extension-clipboard-indicator Jack Hill
2020-05-04 22:40 ` [bug#41088] [PATCH v2] " Jack Hill
@ 2020-05-05 20:12 ` Jack Hill
2020-05-06 20:32 ` bug#41088: " Marius Bakke
1 sibling, 1 reply; 6+ messages in thread
From: Jack Hill @ 2020-05-05 20:12 UTC (permalink / raw)
To: 41088; +Cc: Marius Bakke
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):
New variable.
---
New in this version: Added comment about why compiled schemas and
translations are removed as part of the source snippet.
gnu/packages/gnome-xyz.scm | 47 ++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 625248a25a..41c341fd41 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -148,6 +148,53 @@ GNOME Shell.")
(home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")
(license license:gpl2+)))
+(define-public gnome-shell-extension-clipboard-indicator
+ (package
+ (name "gnome-shell-extension-clipboard-indicator")
+ (version "34")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url (string-append "https://github.com/Tudmotu/"
+ "gnome-shell-extension-clipboard-indicator.git"))
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0i00psc1ky70zljd14jzr627y7nd8xwnwrh4xpajl1f6djabh12s"))
+ (modules '((guix build utils)))
+ (snippet
+ ;; Remove pre-compiled settings schemas and translations from
+ ;; source, as they are generated as part of build. Upstream
+ ;; includes them for people who want to run the software
+ ;; directly from source tree.
+ '(begin (delete-file "schemas/gschemas.compiled")
+ (for-each delete-file (find-files "locale" "\\.mo$"))
+ #t))))
+ (build-system copy-build-system)
+ (arguments
+ '(#:install-plan
+ '(("." "share/gnome-shell/extensions/clipboard-indicator@tudmotu.com"
+ #:include-regexp ("\\.css$" "\\.compiled$" "\\.js(on)?$" "\\.mo$" "\\.xml$")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'install 'compile-schemas
+ (lambda _
+ (with-directory-excursion "schemas"
+ (invoke "glib-compile-schemas" "."))
+ #t))
+ (add-before 'install 'compile-locales
+ (lambda _ (invoke "./compile-locales.sh")
+ #t)))))
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("glib:bin" ,glib "bin"))) ; for glib-compile-schemas
+ (home-page "https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator")
+ (synopsis "Clipboard manager extension for GNOME Shell")
+ (description "Clipboard Indicator is a clipboard manager for GNOME Shell
+that caches clipboard history.")
+ (license license:expat)))
+
(define-public gnome-shell-extension-topicons-redux
(package
(name "gnome-shell-extension-topicons-redux")
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-06 20:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 22:30 [bug#41088] [PATCH] gnu: Add gnome-shell-extension-clipboard-indicator Jack Hill
2020-05-04 22:40 ` [bug#41088] [PATCH v2] " Jack Hill
2020-05-05 18:06 ` Marius Bakke
2020-05-05 20:11 ` Jack Hill
2020-05-05 20:12 ` [bug#41088] [PATCH v3] " Jack Hill
2020-05-06 20:32 ` bug#41088: " Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).