unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jack Hill <jackhill@jackhill.us>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 41088@debbugs.gnu.org
Subject: [bug#41088] [PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator.
Date: Tue, 5 May 2020 16:11:03 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.2005051606340.5735@marsh.hcoop.net> (raw)
In-Reply-To: <87imhaxnnb.fsf@devup.no>


On Tue, 5 May 2020, Marius Bakke wrote:

> Jack Hill <jackhill@jackhill.us> writes:
>
>> +              (snippet
>> +               '(begin (delete-file "schemas/gschemas.compiled")
>> +                       (for-each delete-file (find-files "locale" "\\.mo$"))
>> +                       #t))))
>
> Can you add a comment about why this is necessary?

I've added a commend and will send the updated patch shortly. However, I 
may have been wrong to remove these files as part of the snippet. I did it 
because the removed files are not source form, but instead can be 
generated from source during the package build. I believe that upstream 
includes them in the code repository because it is common for people to 
install GNOME Shell extensions by directly cloning the repo in their home 
directories.

> Otherwise LGTM.

Thanks for the review.

Best,
Jack




  reply	other threads:[~2020-05-05 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 22:30 [bug#41088] [PATCH] gnu: Add gnome-shell-extension-clipboard-indicator Jack Hill
2020-05-04 22:40 ` [bug#41088] [PATCH v2] " Jack Hill
2020-05-05 18:06   ` Marius Bakke
2020-05-05 20:11     ` Jack Hill [this message]
2020-05-05 20:12 ` [bug#41088] [PATCH v3] " Jack Hill
2020-05-06 20:32   ` bug#41088: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.2005051606340.5735@marsh.hcoop.net \
    --to=jackhill@jackhill.us \
    --cc=41088@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).