* [bug#42457] [PATCH] gnu: knights: Fix build.
@ 2020-07-21 6:11 Jesse Gibbons
2020-07-25 12:16 ` Oleg Pykhalov
0 siblings, 1 reply; 4+ messages in thread
From: Jesse Gibbons @ 2020-07-21 6:11 UTC (permalink / raw)
To: 42457
* gnu/packages/games.scm (knights):
[make-flags] add "CXXFLAGS=-lpthread"
---
gnu/packages/games.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index cff1c0af99..dc0511e55a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1366,7 +1366,8 @@ built-in level editor.")
(build-system gnu-build-system)
(arguments
'(#:make-flags
- (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+ "CXXFLAGS=-lpthread")
#:phases
(modify-phases %standard-phases
;; No configure script.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#42457] [PATCH] gnu: knights: Fix build.
2020-07-21 6:11 [bug#42457] [PATCH] gnu: knights: Fix build Jesse Gibbons
@ 2020-07-25 12:16 ` Oleg Pykhalov
2020-07-28 4:05 ` Jesse Gibbons
0 siblings, 1 reply; 4+ messages in thread
From: Oleg Pykhalov @ 2020-07-25 12:16 UTC (permalink / raw)
To: Jesse Gibbons; +Cc: 42457
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
Hi,
Jesse Gibbons <jgibbons2357@gmail.com> writes:
> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"
> ---
> gnu/packages/games.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
> (build-system gnu-build-system)
> (arguments
> '(#:make-flags
> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> + "CXXFLAGS=-lpthread")
> #:phases
> (modify-phases %standard-phases
> ;; No configure script.
This patch looks broken for me, could you resend it, please?
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#42457] [PATCH] gnu: knights: Fix build.
2020-07-25 12:16 ` Oleg Pykhalov
@ 2020-07-28 4:05 ` Jesse Gibbons
2020-07-28 18:13 ` bug#42457: " Oleg Pykhalov
0 siblings, 1 reply; 4+ messages in thread
From: Jesse Gibbons @ 2020-07-28 4:05 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 42457
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
Attached.
On 7/25/20 6:16 AM, Oleg Pykhalov wrote:
> Hi,
>
> Jesse Gibbons <jgibbons2357@gmail.com> writes:
>
>> * gnu/packages/games.scm (knights):
>> [make-flags] add "CXXFLAGS=-lpthread"
>> ---
>> gnu/packages/games.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
>> index cff1c0af99..dc0511e55a 100644
>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>> @@ -1366,7 +1366,8 @@ built-in level editor.")
>> (build-system gnu-build-system)
>> (arguments
>> '(#:make-flags
>> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
>> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
>> + "CXXFLAGS=-lpthread")
>> #:phases
>> (modify-phases %standard-phases
>> ;; No configure script.
> This patch looks broken for me, could you resend it, please?
>
> Thanks,
> Oleg.
[-- Attachment #2: 0001-gnu-knights-Fix-build.patch --]
[-- Type: text/x-patch, Size: 907 bytes --]
From 6608c7ce9057a9bc38df723b38523aad5c05d41e Mon Sep 17 00:00:00 2001
From: Jesse Gibbons <jgibbons2357+guix@gmail.com>
Date: Sun, 5 Apr 2020 20:47:02 -0600
Subject: [PATCH 1/1] gnu: knights: Fix build.
* gnu/packages/games.scm (knights):
[make-flags] add "CXXFLAGS=-lpthread"
---
gnu/packages/games.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index cff1c0af99..dc0511e55a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1366,7 +1366,8 @@ built-in level editor.")
(build-system gnu-build-system)
(arguments
'(#:make-flags
- (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+ (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
+ "CXXFLAGS=-lpthread")
#:phases
(modify-phases %standard-phases
;; No configure script.
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#42457: [PATCH] gnu: knights: Fix build.
2020-07-28 4:05 ` Jesse Gibbons
@ 2020-07-28 18:13 ` Oleg Pykhalov
0 siblings, 0 replies; 4+ messages in thread
From: Oleg Pykhalov @ 2020-07-28 18:13 UTC (permalink / raw)
To: Jesse Gibbons; +Cc: 42457-done
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Hi,
[…]
> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"
Rather:
* gnu/packages/games.scm (knights)[arguments]<#:make-flags>: Add
"CXXFLAGS=-lpthread".
> ---
> gnu/packages/games.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
> (build-system gnu-build-system)
> (arguments
> '(#:make-flags
> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> + "CXXFLAGS=-lpthread")
^
Please, use spaces instead of tabs. ;-)
> #:phases
> (modify-phases %standard-phases
> ;; No configure script.
Pushed to master with mentioned changes.
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-28 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 6:11 [bug#42457] [PATCH] gnu: knights: Fix build Jesse Gibbons
2020-07-25 12:16 ` Oleg Pykhalov
2020-07-28 4:05 ` Jesse Gibbons
2020-07-28 18:13 ` bug#42457: " Oleg Pykhalov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).