From: Oleg Pykhalov <go.wigust@gmail.com>
To: Jesse Gibbons <jgibbons2357@gmail.com>
Cc: 42457-done@debbugs.gnu.org
Subject: bug#42457: [PATCH] gnu: knights: Fix build.
Date: Tue, 28 Jul 2020 21:13:17 +0300 [thread overview]
Message-ID: <87ime7mrsy.fsf@gmail.com> (raw)
In-Reply-To: <6b0f84d5-7440-5829-cc78-49b30d35ad88@gmail.com> (Jesse Gibbons's message of "Mon, 27 Jul 2020 22:05:13 -0600")
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Hi,
[…]
> * gnu/packages/games.scm (knights):
> [make-flags] add "CXXFLAGS=-lpthread"
Rather:
* gnu/packages/games.scm (knights)[arguments]<#:make-flags>: Add
"CXXFLAGS=-lpthread".
> ---
> gnu/packages/games.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index cff1c0af99..dc0511e55a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -1366,7 +1366,8 @@ built-in level editor.")
> (build-system gnu-build-system)
> (arguments
> '(#:make-flags
> - (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> + "CXXFLAGS=-lpthread")
^
Please, use spaces instead of tabs. ;-)
> #:phases
> (modify-phases %standard-phases
> ;; No configure script.
Pushed to master with mentioned changes.
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-07-28 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 6:11 [bug#42457] [PATCH] gnu: knights: Fix build Jesse Gibbons
2020-07-25 12:16 ` Oleg Pykhalov
2020-07-28 4:05 ` Jesse Gibbons
2020-07-28 18:13 ` Oleg Pykhalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ime7mrsy.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=42457-done@debbugs.gnu.org \
--cc=jgibbons2357@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).