From: Christopher Baines <mail@cbaines.net>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 44191@debbugs.gnu.org, nicolo@nixo.xyz
Subject: [bug#44191] gnu: Add kristall
Date: Mon, 26 Oct 2020 16:43:24 +0000 [thread overview]
Message-ID: <87imaxym37.fsf@cbaines.net> (raw)
In-Reply-To: <87tuui1ce2.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
Nicolò Balzarotti <anothersms@gmail.com> writes:
> Hi Chris!
>
> Thanks for the review.
>
> I tried, but:
> 1. breeze is a different package from the ones in the repo (url is
> https://github.com/Alexhuszagh/BreezeStyleSheets). It does not seems to
> be compiled, I can try to package it.
> 2. there are files in lib/cmark that are not present in the cmark
> distribution (thei are .h files generated by their .h.in), so I cannot
> extract our cmark source directly
> - I tried keeping those files, but build fails [[failed-build]]. Not sure if it's
> a patched version or if it's an older one. But I can investigate
> probably
I think you might be overcomplicating this. kristall shouldn't be trying
to build cmark, as it's a library, it should just be linking against
it. Therefore, you shouldn't need to keep the .h.in files.
Making kristall use cmark, rather than the copy in the kristall source
probably requires adapting/fixing src/kristall.pro.
It hopefully isn't that difficult, but I don't know what this .pro file
is, it also looks pretty odd in parts, especially the references to
/home/felix/... !
It doesn't look like the copy of cmark in the kristall source has been
modified much, which also raises the question of why there is a copy of
the cmark source inside kristall?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2020-10-26 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 13:07 [bug#44191] gnu: Add kristall Nicolò Balzarotti
2020-10-25 9:47 ` Christopher Baines
2020-10-25 16:47 ` Nicolò Balzarotti
2020-10-26 16:43 ` Christopher Baines [this message]
2020-10-26 18:12 ` Nicolò Balzarotti
2020-10-27 13:22 ` Nicolò Balzarotti
2020-10-31 20:26 ` Christopher Baines
2020-11-03 10:14 ` Nicolò Balzarotti
2020-11-10 19:57 ` Christopher Baines
2020-11-14 14:52 ` Nicolò Balzarotti
2020-11-14 16:23 ` bug#44191: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imaxym37.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=44191@debbugs.gnu.org \
--cc=anothersms@gmail.com \
--cc=nicolo@nixo.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).