unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 44191@debbugs.gnu.org, nicolo@nixo.xyz
Subject: [bug#44191] gnu: Add kristall
Date: Sun, 25 Oct 2020 09:47:45 +0000	[thread overview]
Message-ID: <87o8kqab7i.fsf@cbaines.net> (raw)
In-Reply-To: <8736233h7h.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]


Nicolò Balzarotti <anothersms@gmail.com> writes:

> Hi guix!
>
> This patch adds kristall, a qt browser for gemini and gopher.
>
> There were some problems with the latest tagged version (V0.3), such as
> directories that had to be created manually before install.  I preferred
> to use the latest commit (as the author still does not know when a new
> release will happen).  Let me know if it's fine.
>
> Without the wrap-qt-program icons were missing.
>
> guix lint reports no warnings.

Hey!

Thanks for the patch.

I've had a quick look, and spotted one thing. The Git repository
includes lib/BreezeStyleSheets and lib/cmark, which are both packaged
for Guix (I'm unsure about luis-l-gist). It would be good to look at
removing/not using the copied code from kristall and using the Guix
packages instead.

Does that make sense?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2020-10-25  9:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-24 13:07 [bug#44191] gnu: Add kristall Nicolò Balzarotti
2020-10-25  9:47 ` Christopher Baines [this message]
2020-10-25 16:47   ` Nicolò Balzarotti
2020-10-26 16:43     ` Christopher Baines
2020-10-26 18:12       ` Nicolò Balzarotti
2020-10-27 13:22         ` Nicolò Balzarotti
2020-10-31 20:26           ` Christopher Baines
2020-11-03 10:14             ` Nicolò Balzarotti
2020-11-10 19:57               ` Christopher Baines
2020-11-14 14:52                 ` Nicolò Balzarotti
2020-11-14 16:23                   ` bug#44191: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8kqab7i.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=44191@debbugs.gnu.org \
    --cc=anothersms@gmail.com \
    --cc=nicolo@nixo.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).