From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MAHTHuP8ll/CRQAA0tVLHw (envelope-from ) for ; Mon, 26 Oct 2020 16:44:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4HVnGuP8ll8YMgAAbx9fmQ (envelope-from ) for ; Mon, 26 Oct 2020 16:44:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E89F9408F0 for ; Mon, 26 Oct 2020 16:44:19 +0000 (UTC) Received: from localhost ([::1]:35638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX5bV-0008Fo-TP for larch@yhetil.org; Mon, 26 Oct 2020 12:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX5bG-0008CJ-MQ for guix-patches@gnu.org; Mon, 26 Oct 2020 12:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kX5bG-0003Wf-DN for guix-patches@gnu.org; Mon, 26 Oct 2020 12:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kX5bG-0005nZ-Bu for guix-patches@gnu.org; Mon, 26 Oct 2020 12:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44191] gnu: Add kristall Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Oct 2020 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44191 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Cc: 44191@debbugs.gnu.org, nicolo@nixo.xyz Received: via spool by 44191-submit@debbugs.gnu.org id=B44191.160373061322247 (code B ref 44191); Mon, 26 Oct 2020 16:44:02 +0000 Received: (at 44191) by debbugs.gnu.org; 26 Oct 2020 16:43:33 +0000 Received: from localhost ([127.0.0.1]:41085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX5am-0005mk-Qf for submit@debbugs.gnu.org; Mon, 26 Oct 2020 12:43:33 -0400 Received: from mira.cbaines.net ([212.71.252.8]:35902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX5ak-0005mc-Fs for 44191@debbugs.gnu.org; Mon, 26 Oct 2020 12:43:31 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 8A2C527BBF1; Mon, 26 Oct 2020 16:43:29 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 46c05ab4; Mon, 26 Oct 2020 16:43:27 +0000 (UTC) References: <8736233h7h.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87o8kqab7i.fsf@cbaines.net> <87tuui1ce2.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87tuui1ce2.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Date: Mon, 26 Oct 2020 16:43:24 +0000 Message-ID: <87imaxym37.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 2.0 (++) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 1.0 (+) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: +nfEBgbNwVHn --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Nicol=C3=B2 Balzarotti writes: > Hi Chris! > > Thanks for the review. > > I tried, but: > 1. breeze is a different package from the ones in the repo (url is > https://github.com/Alexhuszagh/BreezeStyleSheets). It does not seems to > be compiled, I can try to package it. > 2. there are files in lib/cmark that are not present in the cmark > distribution (thei are .h files generated by their .h.in), so I cannot > extract our cmark source directly > - I tried keeping those files, but build fails [[failed-build]]. Not = sure if it's > a patched version or if it's an older one. But I can investigate > probably I think you might be overcomplicating this. kristall shouldn't be trying to build cmark, as it's a library, it should just be linking against it. Therefore, you shouldn't need to keep the .h.in files. Making kristall use cmark, rather than the copy in the kristall source probably requires adapting/fixing src/kristall.pro. It hopefully isn't that difficult, but I don't know what this .pro file is, it also looks pretty odd in parts, especially the references to /home/felix/... ! It doesn't look like the copy of cmark in the kristall source has been modified much, which also raises the question of why there is a copy of the cmark source inside kristall? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+W/KxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe94xAAhFeEOwS90Cse87J+jWhaY68P/x7WDqvr jY6U85/E+EmBGdaEC7o2qognlePfQV/YZK6NNiQFRTGNGAG5XlDJ1h6CukTPmLhC Ilh6RiyLgUnMKKwhvtGiw4ahoR8qskEkuX7pKzVwO6fY95p1/Ffj6OWCh+Y3Wn9p uV3CSUyjsIu/r0JFAAfcpzyN7Ov2K00T8h1s1bDskEyBm7qhhbwzHZhQYCZgfIXg /+EJfhtNd/nATpkPdz1eoXs+9d96hIbxqUio0O3R1GmPTwP+gmWNIaE4oWoWA8wo zh61Y18ntYq14Zgqnz2KlPZTRauG6cvsExY4MaAu729TWcYSOGxuLk6Mf/2AugmW S6mvJ1w1ECscruELjvwJndy7PcOjOuJKdmPoxDIUgcSsCefHeyLraKjB5nPkM4/P ASNyllFHEd7R+heFp3P0LfGANxTbpf9gYJWIOG/gsVQH+U2a+3g3lng7Sbpaikqu 5xvD3EAI83dlX2JaR7JUWfNXDk2RoAvJUhfd0boDzeTBp1O0XQXSH+nmI6pRQhnA LbZV6AcjIz48I/laJQYCuhkv6JoWcFnJFVmrhbHkRCmjDLzU6KuczWtMNNAzHPoy cXZcmV+WeIY6hNtmwmlJ3Xv77sxbL8HbeERV/TRB9fwB6Scfobc20i7qbRxELD+w hl85+TTM8sI= =L3K9 -----END PGP SIGNATURE----- --=-=-=--