From: Ricardo Wurmus <rekado@elephly.net>
To: 57297@debbugs.gnu.org
Subject: [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers
Date: Thu, 01 Sep 2022 09:44:04 +0200 [thread overview]
Message-ID: <87ilm7r0vw.fsf@elephly.net> (raw)
In-Reply-To: <cover.1660919376.git.kaelyn.alexi@protonmail.com>
Thank you for the patches. Overall they look good to me, but I have
some comments:
- the first patch updates spriv-headers from 1.5.3 to 1.2.198.0. This
looks like a downgrade. Is this jump in version numbers expected?
- the commit message for the vulkan-loader update should mention the
changes in the build system arguments:
* gnu/packages/vulkan.scm (vulkan-loader): Update to 1.2.202.
[arguments]: Enable tests by removing obsolete build phase
'disable-loader-tests and adjusting configure flags.
- in the patch for vulkan-validationlayers I’d use #$output instead of
binding out to (assoc-ref outputs "out").
Other than that this all looks good to me!
--
Ricardo
next prev parent reply other threads:[~2022-09-01 8:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 14:48 [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-08-19 14:50 ` [bug#57297] [PATCH 1/7] gnu: spirv-headers: Update to 1.2.198.0 Kaelyn Takata via Guix-patches via
2022-08-19 14:50 ` [bug#57297] [PATCH 2/7] gnu: spirv-tools: Update to 2021.4 Kaelyn Takata via Guix-patches via
2022-08-19 14:50 ` [bug#57297] [PATCH 3/7] gnu: vulkan-headers: Update to 1.2.202 Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 4/7] gnu: vulkan-loader: " Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 5/7] gnu: vulkan-tools: Update to 1.2.201 Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 6/7] gnu: shaderc: Update to 2021.3 Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 7/7] gnu: Add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-09-01 7:44 ` Ricardo Wurmus [this message]
2022-09-01 16:26 ` [bug#57297] [PATCH v2 0/7] Update vulkan packages and add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-09-01 16:26 ` [bug#57297] [PATCH v2 1/7] gnu: spirv-headers: Update to 1.2.198.0 Kaelyn Takata via Guix-patches via
2022-09-01 16:26 ` [bug#57297] [PATCH v2 2/7] gnu: spirv-tools: Update to 2021.4 Kaelyn Takata via Guix-patches via
2022-09-01 16:27 ` [bug#57297] [PATCH v2 3/7] gnu: vulkan-headers: Update to 1.2.202 Kaelyn Takata via Guix-patches via
2022-09-01 16:27 ` [bug#57297] [PATCH v2 4/7] gnu: vulkan-loader: " Kaelyn Takata via Guix-patches via
2022-09-01 16:27 ` [bug#57297] [PATCH v2 5/7] gnu: vulkan-tools: Update to 1.2.201 Kaelyn Takata via Guix-patches via
2022-09-01 16:27 ` [bug#57297] [PATCH v2 6/7] gnu: shaderc: Update to 2021.3 Kaelyn Takata via Guix-patches via
2022-09-01 16:27 ` [bug#57297] [PATCH v2 7/7] gnu: Add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-09-01 17:17 ` bug#57297: [PATCH v2 0/7] Update vulkan packages and add vulkan-validationlayers Ricardo Wurmus
2022-09-16 6:34 ` [bug#57297] [PATCH " Ricardo Wurmus
2022-09-16 14:26 ` Kaelyn via Guix-patches via
2022-10-15 16:52 ` Kaelyn via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilm7r0vw.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=57297@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).