From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SOMKEMxrEGNF7QAAbAwnHQ (envelope-from ) for ; Thu, 01 Sep 2022 10:22:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uFIsD8xrEGN5lAAAG6o9tA (envelope-from ) for ; Thu, 01 Sep 2022 10:22:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6995D217A9 for ; Thu, 1 Sep 2022 10:22:35 +0200 (CEST) Received: from localhost ([::1]:38170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTfT7-00079P-0S for larch@yhetil.org; Thu, 01 Sep 2022 04:22:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTewg-00011q-HU for guix-patches@gnu.org; Thu, 01 Sep 2022 03:49:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTewg-00036V-7N for guix-patches@gnu.org; Thu, 01 Sep 2022 03:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTewf-0006QY-UI for guix-patches@gnu.org; Thu, 01 Sep 2022 03:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers References: In-Reply-To: Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Sep 2022 07:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57297 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57297@debbugs.gnu.org Received: via spool by 57297-submit@debbugs.gnu.org id=B57297.166201851324670 (code B ref 57297); Thu, 01 Sep 2022 07:49:01 +0000 Received: (at 57297) by debbugs.gnu.org; 1 Sep 2022 07:48:33 +0000 Received: from localhost ([127.0.0.1]:41068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTewD-0006Pq-3q for submit@debbugs.gnu.org; Thu, 01 Sep 2022 03:48:33 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTew9-0006Pd-Sz for 57297@debbugs.gnu.org; Thu, 01 Sep 2022 03:48:32 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1662018504; cv=none; d=zohomail.com; s=zohoarc; b=d+chi8A6NhOd1yUNIUHi4bT3sYAO4TTEzPOtXkWZNE7SDLc2zT2FxzA3T84g80xpFGZLZpsSIu9vU6XTNUvAu7jP6Mwf3uomEFuI5Dd0Memj7YU8GeVPANe4bC3tNvWv4/0BNfy7CdaQDc3gE8aspMhxbYYRkDf8mOU8pPxtd98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1662018504; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=pol/eRzUuzXPUM/grvwgi67aoC8uIaINktomJLzxtlk=; b=KLpYfHodk9nPKNmnp1B11ALrz4pOXFG+VURlosKHvQHI9BuVNZUY8AzPjKh+0n+e7zWLq8V/CDSmZ+iGqU5zX0Hx/L5UAeFHX77Wor1XExD03kf643bk6AQPVvbqXkYvGx60CJbzYHDttBCfzMCiHd5PwE/fIAJFpceAQcDkK4s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1662018504; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=pol/eRzUuzXPUM/grvwgi67aoC8uIaINktomJLzxtlk=; b=QnTssxiiUDdO6Bo5lLSnQIJE8qS+g0GFy7yB+/xGEscVzd7m28eaT0ysXyIt5FYC UtbF2osDpn69CGYOD2TKR4HLRIzmEwHY9Pct4VEvioJSjTQHb3ex/ntBbmztrQ/ky0W 96dRlefE4zyJGFH9x1gJeklV+eOXwSoljsImcQp4= Received: from localhost (i5E862C74.versanet.de [94.134.44.116]) by mx.zohomail.com with SMTPS id 1662018502425881.9566588973131; Thu, 1 Sep 2022 00:48:22 -0700 (PDT) User-agent: mu4e 1.8.7; emacs 28.1 From: Ricardo Wurmus Date: Thu, 01 Sep 2022 09:44:04 +0200 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87ilm7r0vw.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662020556; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pol/eRzUuzXPUM/grvwgi67aoC8uIaINktomJLzxtlk=; b=gLuyNw5QxKSpISgDk1/MkRJiAa1+EoohP/ehGOzWpuj8DRNU9J961mIeHOu7+118h9arqh gt7cXJmlIStOqacZ4vrm4w4SdbP3Xqo6OTuklhfSCRhs7Sy5gCmBhPeuTYnm5pTBw3eiIz 5x987V2SGDjR8aRZFMJKHqJafuVTM9QDa6dswulHr8tWUmo6nCnjzIEXSkttHjwIgVlEGz oaxWk+U5N8decyQQHgz9XQIdLose4Ww+DfMDI1rJJ8Yus7Uis1vCwYLVEmN1PcidN2JBpM aJzoYBiManNRNJSssczDhLgpUXtODwBOZJQqtgn0SccaR8FRnQd++eCl9qYP/g== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1662020556; a=rsa-sha256; cv=fail; b=srM1qX3e2LJP7DVCfYYDAkNi1fcp5FbfsMcZyVAclmcH9z+mg8BfKQdYh6Z04bSloeh7la 1j8rgcS73EMKgKm7v6VgMVIittJy66J9n4HiU5+yNweX4Pp5ioiFeQkehEYswetzp9pSOw BQAVq7tWjzx0HKVB4rx49LpC8Sk6+mLSV1t8S5GwV+UKN0eNDBwtz4NKu/dp4oiHydjxHd Trxa3cJ9AAfEaADa7j0tlWyRpaPUGSodETtXsFctHfy4obooIUtJzVtzMNqvqVJuchpodJ fcs5jwNu5Ex25/8a68bYR4LmadVEd29gIuDssH4up25lj/qQKW36m7jyt2OfMQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=QnTssxii; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=QnTssxii; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6995D217A9 X-Spam-Score: 2.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: O9ewKHoWYW/2 Thank you for the patches. Overall they look good to me, but I have some comments: - the first patch updates spriv-headers from 1.5.3 to 1.2.198.0. This looks like a downgrade. Is this jump in version numbers expected? - the commit message for the vulkan-loader update should mention the changes in the build system arguments: * gnu/packages/vulkan.scm (vulkan-loader): Update to 1.2.202. [arguments]: Enable tests by removing obsolete build phase 'disable-loader-tests and adjusting configure flags. - in the patch for vulkan-validationlayers I=E2=80=99d use #$output instead= of binding out to (assoc-ref outputs "out"). Other than that this all looks good to me! --=20 Ricardo