unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kaelyn via Guix-patches via <guix-patches@gnu.org>
To: "57297@debbugs.gnu.org" <57297@debbugs.gnu.org>
Subject: [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers
Date: Sat, 15 Oct 2022 16:52:50 +0000	[thread overview]
Message-ID: <2o7t-mYP44dN-oEu5yYNU528NSlrooJeZ05XVNcIReGdOBr1vU4obmavgxoYLLh7-yAMqwnmx380F23JzY9emxbyr6eUKKHbQtmnyeL0Jfk=@protonmail.com> (raw)
In-Reply-To: <cover.1660919376.git.kaelyn.alexi@protonmail.com>

Hi,

Sorry for the long period of silence on this patch set! I have finally found a fix for the mpv build failure with the updated spirv-headers and spirv-tools (and likely any others that failed with similar undefined symbols as well). While trying to figure out why mpv wasn't building when other distros have been shipping the same version of mpv against updated spirv & vulkan packages, I started examining their package definitions to see why that may be.

The fix is to add "-DSPIRV_TOOLS_BUILD_STATIC=OFF" to the configure flags for spirv-tools. Apparently a change to spirv-tools in late 2020 caused issues when statically linking (lost the link to the ML thread), and the common packaging approach seems to be to disable the static libs with that flag[1][2].

Quick question on procedure: would it be better to send to this bug a revised version of the single patch (#2 of 7), or to rebase the set against the tip of the staging branch and send in a v3 of all 7 patches?

Cheers,
Kaelyn


[1] https://github.com/archlinux/svntogit-packages/blob/packages/spirv-tools/trunk/PKGBUILD#L27
[2] https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/spirv-tools/spirv-tools-1.3.224.ebuild#n39





      parent reply	other threads:[~2022-10-15 16:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 14:48 [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-08-19 14:50 ` [bug#57297] [PATCH 1/7] gnu: spirv-headers: Update to 1.2.198.0 Kaelyn Takata via Guix-patches via
2022-08-19 14:50 ` [bug#57297] [PATCH 2/7] gnu: spirv-tools: Update to 2021.4 Kaelyn Takata via Guix-patches via
2022-08-19 14:50 ` [bug#57297] [PATCH 3/7] gnu: vulkan-headers: Update to 1.2.202 Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 4/7] gnu: vulkan-loader: " Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 5/7] gnu: vulkan-tools: Update to 1.2.201 Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 6/7] gnu: shaderc: Update to 2021.3 Kaelyn Takata via Guix-patches via
2022-08-19 14:51 ` [bug#57297] [PATCH 7/7] gnu: Add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-09-01  7:44 ` [bug#57297] [PATCH 0/7] Update vulkan packages and add vulkan-validationlayers Ricardo Wurmus
2022-09-01 16:26 ` [bug#57297] [PATCH v2 " Kaelyn Takata via Guix-patches via
2022-09-01 16:26   ` [bug#57297] [PATCH v2 1/7] gnu: spirv-headers: Update to 1.2.198.0 Kaelyn Takata via Guix-patches via
2022-09-01 16:26   ` [bug#57297] [PATCH v2 2/7] gnu: spirv-tools: Update to 2021.4 Kaelyn Takata via Guix-patches via
2022-09-01 16:27   ` [bug#57297] [PATCH v2 3/7] gnu: vulkan-headers: Update to 1.2.202 Kaelyn Takata via Guix-patches via
2022-09-01 16:27   ` [bug#57297] [PATCH v2 4/7] gnu: vulkan-loader: " Kaelyn Takata via Guix-patches via
2022-09-01 16:27   ` [bug#57297] [PATCH v2 5/7] gnu: vulkan-tools: Update to 1.2.201 Kaelyn Takata via Guix-patches via
2022-09-01 16:27   ` [bug#57297] [PATCH v2 6/7] gnu: shaderc: Update to 2021.3 Kaelyn Takata via Guix-patches via
2022-09-01 16:27   ` [bug#57297] [PATCH v2 7/7] gnu: Add vulkan-validationlayers Kaelyn Takata via Guix-patches via
2022-09-01 17:17 ` bug#57297: [PATCH v2 0/7] Update vulkan packages and add vulkan-validationlayers Ricardo Wurmus
2022-09-16  6:34 ` [bug#57297] [PATCH " Ricardo Wurmus
2022-09-16 14:26   ` Kaelyn via Guix-patches via
2022-10-15 16:52 ` Kaelyn via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='2o7t-mYP44dN-oEu5yYNU528NSlrooJeZ05XVNcIReGdOBr1vU4obmavgxoYLLh7-yAMqwnmx380F23JzY9emxbyr6eUKKHbQtmnyeL0Jfk=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=57297@debbugs.gnu.org \
    --cc=kaelyn.alexi@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).