From: "Ludovic Courtès" <ludo@gnu.org>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: 58623@debbugs.gnu.org
Subject: [bug#58623] [PATCH 0/3] import/cran: Parameterize for guix-cran.
Date: Sat, 05 Nov 2022 21:47:50 +0100 [thread overview]
Message-ID: <87iljti0w9.fsf@gnu.org> (raw)
In-Reply-To: <Y0/DVVjwYCtiDRxd@noor.fritz.box> (Lars-Dominik Braun's message of "Wed, 19 Oct 2022 11:28:53 +0200")
Hi!
Lars-Dominik Braun <lars@6xq.net> skribis:
> the attached patches are required for guix-cran
> (https://github.com/guix-science/guix-cran). import/cran already has the
> ability to add a prefix to licenses, but it was not exposed. Additionally
> I need to parameterize fetch/download functions, so I can cache the
> tarballs/DESCRIPTION files.
Nice! Minor comments:
> +(define %license-prefix
> + (make-parameter identity))
Overall, unless it’s impractical, I’d suggest using explicit keyword
parameters instead of SRFI-39 parameters (like this one). That makes
things clearer. (That’s essentially lexical scope vs. dynamic scope.)
Also, when introducing a public global variable, please add a short
comment below the ‘define’ line explaining what it does.
> +++ b/guix/scripts/import/cran.scm
> @@ -53,6 +53,9 @@ (define (show-help)
> (display (G_ "
> -s, --style=STYLE choose output style, either specification or variable"))
> (display (G_ "
> + -p, --license-prefix=PREFIX
> + add custom prefix to licenses, useful for prefixed import of (guix licenses)"))
I agree with zimoun that this should be documented in the manual. I’d
also remove everything after the comma.
> +(define %fetch-description
> + (make-parameter fetch-description))
Same comment as above.
> +(define %download-source
> + (make-parameter download))
Ditto.
Thanks!
Ludo’.
next prev parent reply other threads:[~2022-11-05 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 9:28 [bug#58623] [PATCH 0/3] import/cran: Parameterize for guix-cran Lars-Dominik Braun
2022-11-02 18:25 ` zimoun
2022-11-05 20:47 ` Ludovic Courtès [this message]
2022-11-30 16:47 ` [bug#58623] [PATCH v2 0/6] " Lars-Dominik Braun
2022-12-01 11:05 ` Lars-Dominik Braun
2022-12-31 13:49 ` bug#58623: [PATCH 0/3] " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iljti0w9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=58623@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).