From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8KWvLQ3MZmN1BwAAbAwnHQ (envelope-from ) for ; Sat, 05 Nov 2022 21:48:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yG/NLA3MZmPQvAAAG6o9tA (envelope-from ) for ; Sat, 05 Nov 2022 21:48:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 261FC3BAD3 for ; Sat, 5 Nov 2022 21:48:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orQ5H-0007zp-Et; Sat, 05 Nov 2022 16:48:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orQ5C-0007xv-HZ for guix-patches@gnu.org; Sat, 05 Nov 2022 16:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orQ5C-0000b6-96 for guix-patches@gnu.org; Sat, 05 Nov 2022 16:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orQ5C-0001g5-0D for guix-patches@gnu.org; Sat, 05 Nov 2022 16:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58623] [PATCH 0/3] import/cran: Parameterize for guix-cran. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Nov 2022 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58623 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 58623@debbugs.gnu.org Received: via spool by 58623-submit@debbugs.gnu.org id=B58623.16676812816438 (code B ref 58623); Sat, 05 Nov 2022 20:48:01 +0000 Received: (at 58623) by debbugs.gnu.org; 5 Nov 2022 20:48:01 +0000 Received: from localhost ([127.0.0.1]:58170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orQ5A-0001fk-J9 for submit@debbugs.gnu.org; Sat, 05 Nov 2022 16:48:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orQ58-0001f3-U5 for 58623@debbugs.gnu.org; Sat, 05 Nov 2022 16:47:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orQ52-0000YF-MP; Sat, 05 Nov 2022 16:47:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=bMWg3g1nboh39OPonG33b0zTHaUgYdGxmCsBC7Hp0y0=; b=fdI5JO+xH2lW1NSNVmb6 Iw20EWlpJ+p/QxdRA3luMIrAWf9TwViBsclaSg5qXKzOWq+nZNxaKpmS4a6+j71eo8JZgxczkMobY abEM8ZBc08uBT/DHqwz4UNb6Bo4l/ObC1oMRqe5d9BRSGryNBecRtW+VVESbqlzAmIW5LK7J6my27 9ouzaXQDJWHYnbyDFoc0dT494SCDjHO4WOaGLGCtzD8N2SawBdHpwAQdRK17zP7Z8/TW3G085Ru2u aFY4vFy0lXJvqc4SQehvsNO2MS08GDBO6UQx0wP4CRKyP14GGNN34qrLuqpdRZP9CxBjX3ztvfT3L 0o/C3MRoYzxkpw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orQ52-0007IK-8q; Sat, 05 Nov 2022 16:47:52 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Brumaire an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Dindon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 05 Nov 2022 21:47:50 +0100 In-Reply-To: (Lars-Dominik Braun's message of "Wed, 19 Oct 2022 11:28:53 +0200") Message-ID: <87iljti0w9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667681293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bMWg3g1nboh39OPonG33b0zTHaUgYdGxmCsBC7Hp0y0=; b=tJyZcMLwQwsb2BHDMWnq/kp83y4X26vAcvCdcV+cWHrD+rZf32gKL6EwJo/xpVL4h8xBjq yd5TK3M3mmZkOA69FAKpa/lbe1mw8cWmBb4rX6VqICFETdcKu7w1+nfmowFka1JrLayEqn G9CroeIa0jwp1EvrQES6A9t7vQnpBgF9mzLGA1rIblYe3ZBcPyPyCEknn96iAJoVD2wU0N 838o9gQwQzmehpHrDZbz6Jn6aBPqOdm8Hp8b8vU5TelxLg99xDMaa3Eub9+DCLx+VllQjx tkxuK12UuoSedpEjEZdNWEIkJJk+3U13v/pqJyOtrWAmrQX6ez013xfJrluSaw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667681293; a=rsa-sha256; cv=none; b=geiJ5gGHOTux44hOdh17v1PFsyyP1gQ6b6TiHyyaE5rf92SzmHFPtp1oscIp9ofuGK987m whUzmG41ajr919K4FMcSgbe2ktQMYRZR9j7MtyQaEheLn2eb9b/LbH0XGlyTjVOwHk+ESx IzTMdzEpLWG1LExLyP6JX+WvpjmVZHXmklYJAHIZpLLxVoc4Bb2VHQtZ2aKIPydxmIbb3x 4unryybny0qvK1YbZVkocHroiCkbb3tIQa5roxqmhEA07FgDxjPeKFEoKnAMjGHwlZ7zA1 kt0bqvwoIxNy7Ty7MI6SIy0dCxQ9GwKb3QxK8NQ4vDTfeMQs5TRDTuiHtOpg/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fdI5JO+x; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fdI5JO+x; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 261FC3BAD3 X-Spam-Score: -2.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: XUlJ69r1DGF0 Hi! Lars-Dominik Braun skribis: > the attached patches are required for guix-cran > (https://github.com/guix-science/guix-cran). import/cran already has the > ability to add a prefix to licenses, but it was not exposed. Additionally > I need to parameterize fetch/download functions, so I can cache the > tarballs/DESCRIPTION files. Nice! Minor comments: > +(define %license-prefix > + (make-parameter identity)) Overall, unless it=E2=80=99s impractical, I=E2=80=99d suggest using explici= t keyword parameters instead of SRFI-39 parameters (like this one). That makes things clearer. (That=E2=80=99s essentially lexical scope vs. dynamic scop= e.) Also, when introducing a public global variable, please add a short comment below the =E2=80=98define=E2=80=99 line explaining what it does. > +++ b/guix/scripts/import/cran.scm > @@ -53,6 +53,9 @@ (define (show-help) > (display (G_ " > -s, --style=3DSTYLE choose output style, either specification or = variable")) > (display (G_ " > + -p, --license-prefix=3DPREFIX > + add custom prefix to licenses, useful for prefi= xed import of (guix licenses)")) I agree with zimoun that this should be documented in the manual. I=E2=80= =99d also remove everything after the comma. > +(define %fetch-description > + (make-parameter fetch-description)) Same comment as above. > +(define %download-source > + (make-parameter download)) Ditto. Thanks! Ludo=E2=80=99.