From: Lars-Dominik Braun <lars@6xq.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: rekado@elephly.net, 58623@debbugs.gnu.org
Subject: [bug#58623] [PATCH v2 0/6] import/cran: Parameterize for guix-cran.
Date: Thu, 1 Dec 2022 12:05:09 +0100 [thread overview]
Message-ID: <Y4iKZciaby7GYVjx@noor.fritz.box> (raw)
In-Reply-To: <Y4eJBoocw9aAgI6R@noor.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 107 bytes --]
Hi,
looks like I missed an inconsistency, which is fixed by the attched, additional patch.
Cheers,
Lars
[-- Attachment #2: 0007-import-cran-Depend-on-gfortran-if-.f-files-are-detec.patch --]
[-- Type: text/plain, Size: 923 bytes --]
From f980c02442ab1cc01787a6cc8462f747ccc5ff11 Mon Sep 17 00:00:00 2001
From: Lars-Dominik Braun <lars@6xq.net>
Date: Thu, 1 Dec 2022 12:00:53 +0100
Subject: [PATCH v2 7/7] import/cran: Depend on gfortran if .f files are
detected too.
There was an inconsistency between tarball-needs-fortran? and
directory-needs-fortran?.
* guix/import/cran.scm (directory-needs-fortran?): Match .f files too.
---
guix/import/cran.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/import/cran.scm b/guix/import/cran.scm
index f130543c4c..c71ff957b6 100644
--- a/guix/import/cran.scm
+++ b/guix/import/cran.scm
@@ -438,7 +438,7 @@ (define cran-guix-name (cut guix-name "r-" <>))
(define (directory-needs-fortran? dir)
"Check if the directory DIR contains Fortran source files."
- (match (find-files dir "\\.f(90|95)$")
+ (match (find-files dir "\\.f(90|95)?$")
(() #f)
(_ #t)))
--
2.37.4
next prev parent reply other threads:[~2022-12-01 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 9:28 [bug#58623] [PATCH 0/3] import/cran: Parameterize for guix-cran Lars-Dominik Braun
2022-11-02 18:25 ` zimoun
2022-11-05 20:47 ` Ludovic Courtès
2022-11-30 16:47 ` [bug#58623] [PATCH v2 0/6] " Lars-Dominik Braun
2022-12-01 11:05 ` Lars-Dominik Braun [this message]
2022-12-31 13:49 ` bug#58623: [PATCH 0/3] " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4iKZciaby7GYVjx@noor.fritz.box \
--to=lars@6xq.net \
--cc=58623@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).