* [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
@ 2017-07-25 18:50 Kei Kebreau
2017-07-25 19:21 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-07-25 18:50 UTC (permalink / raw)
To: 27827; +Cc: Kei Kebreau
* gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
---
gnu/packages/python.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 89c2de63b..03f813411 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5871,7 +5871,11 @@ features useful for text console applications.")
(inherit python2-urwid)
(arguments
(append
- '(#:phases
+ `(;; Explicitly using Python 2 is necessary due the argument list being
+ ;; built from only the 'delete-test_vterm.py' phase and python-urwid's
+ ;; package arguments, which by default assumes the use of Python 3.
+ #:python ,python-2
+ #:phases
(modify-phases %standard-phases
;; Disable the vterm tests because of non-deterministic failures
;; with Python 2. See https://github.com/urwid/urwid/issues/230.
--
2.13.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
2017-07-25 18:50 [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2 Kei Kebreau
@ 2017-07-25 19:21 ` Leo Famulari
2017-07-25 19:30 ` bug#27827: " Kei Kebreau
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2017-07-25 19:21 UTC (permalink / raw)
To: Kei Kebreau; +Cc: 27827
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
Good catch! I didn't test this change with `guix gc --references`, but
if that shows the right thing your end, please push!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#27827: [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
2017-07-25 19:21 ` Leo Famulari
@ 2017-07-25 19:30 ` Kei Kebreau
2017-07-25 19:42 ` [bug#27827] " Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-07-25 19:30 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27827-done
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
>> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
>
> Good catch! I didn't test this change with `guix gc --references`, but
> if that shows the right thing your end, please push!
Yes, python2-urwid shows up now. Prior to the patch it did not.
Pushed to master! Thanks again for the review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
2017-07-25 19:30 ` bug#27827: " Kei Kebreau
@ 2017-07-25 19:42 ` Leo Famulari
2017-08-02 20:45 ` Kei Kebreau
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2017-07-25 19:42 UTC (permalink / raw)
To: Kei Kebreau; +Cc: 27827-done
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Tue, Jul 25, 2017 at 03:30:51PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
>
> > On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
> >> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
> >
> > Good catch! I didn't test this change with `guix gc --references`, but
> > if that shows the right thing your end, please push!
>
> Yes, python2-urwid shows up now. Prior to the patch it did not.
>
> Pushed to master! Thanks again for the review.
I just tested it, and it fails to build for me. But, I've noticed the
urwid test suite is pretty flaky. Let's see if it builds on Hydra.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
2017-07-25 19:42 ` [bug#27827] " Leo Famulari
@ 2017-08-02 20:45 ` Kei Kebreau
2017-08-02 22:47 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2017-08-02 20:45 UTC (permalink / raw)
To: Leo Famulari; +Cc: 27827-done
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Tue, Jul 25, 2017 at 03:30:51PM -0400, Kei Kebreau wrote:
>> Leo Famulari <leo@famulari.name> writes:
>>
>> > On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
>> >> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
>> >
>> > Good catch! I didn't test this change with `guix gc --references`, but
>> > if that shows the right thing your end, please push!
>>
>> Yes, python2-urwid shows up now. Prior to the patch it did not.
>>
>> Pushed to master! Thanks again for the review.
>
> I just tested it, and it fails to build for me. But, I've noticed the
> urwid test suite is pretty flaky. Let's see if it builds on Hydra.
I've since updated my system and wicd-curses still works. Does it build
on Hydra? I haven't been able to check because of 504 HTTP response
codes from https://hydra.gnu.org most of the time.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
2017-08-02 20:45 ` Kei Kebreau
@ 2017-08-02 22:47 ` Leo Famulari
0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2017-08-02 22:47 UTC (permalink / raw)
To: Kei Kebreau; +Cc: 27827-done
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Wed, Aug 02, 2017 at 04:45:21PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> > I just tested it, and it fails to build for me. But, I've noticed the
> > urwid test suite is pretty flaky. Let's see if it builds on Hydra.
>
> I've since updated my system and wicd-curses still works. Does it build
> on Hydra? I haven't been able to check because of 504 HTTP response
> codes from https://hydra.gnu.org most of the time.
I just got a substitute for it, so it must have worked :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-02 22:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 18:50 [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2 Kei Kebreau
2017-07-25 19:21 ` Leo Famulari
2017-07-25 19:30 ` bug#27827: " Kei Kebreau
2017-07-25 19:42 ` [bug#27827] " Leo Famulari
2017-08-02 20:45 ` Kei Kebreau
2017-08-02 22:47 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).