[bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[Kei Kebreau]

* gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
---
 gnu/packages/python.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 89c2de63b..03f813411 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5871,7 +5871,11 @@ features useful for text console applications.")
       (inherit python2-urwid)
       (arguments
        (append
-        '(#:phases
+        `(;; Explicitly using Python 2 is necessary due the argument list being
+          ;; built from only the 'delete-test_vterm.py' phase and python-urwid's
+          ;; package arguments, which by default assumes the use of Python 3.
+          #:python ,python-2
+          #:phases
           (modify-phases %standard-phases
             ;; Disable the vterm tests because of non-deterministic failures
             ;; with Python 2. See https://github.com/urwid/urwid/issues/230.
-- 
2.13.3

[bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.

Good catch! I didn't test this change with `guix gc --references`, but
if that shows the right thing your end, please push!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27827: [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
>> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
>
> Good catch! I didn't test this change with `guix gc --references`, but
> if that shows the right thing your end, please push!

Yes, python2-urwid shows up now. Prior to the patch it did not.

Pushed to master! Thanks again for the review.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Tue, Jul 25, 2017 at 03:30:51PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
> >> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
> >
> > Good catch! I didn't test this change with `guix gc --references`, but
> > if that shows the right thing your end, please push!
> 
> Yes, python2-urwid shows up now. Prior to the patch it did not.
> 
> Pushed to master! Thanks again for the review.

I just tested it, and it fails to build for me. But, I've noticed the
urwid test suite is pretty flaky. Let's see if it builds on Hydra.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Tue, Jul 25, 2017 at 03:30:51PM -0400, Kei Kebreau wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> 
>> > On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
>> >> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
>> >
>> > Good catch! I didn't test this change with `guix gc --references`, but
>> > if that shows the right thing your end, please push!
>> 
>> Yes, python2-urwid shows up now. Prior to the patch it did not.
>> 
>> Pushed to master! Thanks again for the review.
>
> I just tested it, and it fails to build for me. But, I've noticed the
> urwid test suite is pretty flaky. Let's see if it builds on Hydra.

I've since updated my system and wicd-curses still works. Does it build
on Hydra? I haven't been able to check because of 504 HTTP response
codes from https://hydra.gnu.org most of the time.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Wed, Aug 02, 2017 at 04:45:21PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> > I just tested it, and it fails to build for me. But, I've noticed the
> > urwid test suite is pretty flaky. Let's see if it builds on Hydra.
> 
> I've since updated my system and wicd-curses still works. Does it build
> on Hydra? I haven't been able to check because of 504 HTTP response
> codes from https://hydra.gnu.org most of the time.

I just got a substitute for it, so it must have worked :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]