From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: Josselin Poiret <dev@jpoiret.xyz>, 64763@debbugs.gnu.org
Subject: [bug#64763] [PATCH] gnu: commencement: Use system in %final-inputs.
Date: Mon, 07 Aug 2023 17:02:24 +0200 [thread overview]
Message-ID: <87h6pasxof.fsf@gnu.org> (raw)
In-Reply-To: <3e0a5d1957c35a9925aab5600ee02b923584a599.1689934305.git.mail@cbaines.net> (Christopher Baines's message of "Fri, 21 Jul 2023 11:11:45 +0100")
Hi!
Christopher Baines <mail@cbaines.net> skribis:
> Otherwise this causes odd issues, I presume arising from when %current-system
> differs from the system argument passed to %final-inputs.
>
> * gnu/packages/commencement.scm (%final-inputs): Set %current-system to
> system.
Please add a “Fixes …” line in the log.
> gnu/packages/commencement.scm | 51 ++++++++++++++++++-----------------
> 1 file changed, 26 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
> index fe6f025257..e522e70444 100644
> --- a/gnu/packages/commencement.scm
> +++ b/gnu/packages/commencement.scm
> @@ -3459,31 +3459,32 @@ (define-public %final-inputs
[...]
> + (parameterize ((%current-system system))
LGTM! I think that was definitely the intent of
0dd293b4d9095137c9952e16ca951f887b7e7018 (Cc’ing Josselin just in
case).
Thanks,
Ludo’.
PS: I believe the reason we cannot just write:
(define/system-dependent %final-inputs …)
is because we have two places where we do:
(module-ref m '%final-inputs)
which wouldn’t work if ‘%final-inputs’ were a macro, as is the case
with ‘define/system-dependent’.
next prev parent reply other threads:[~2023-08-07 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:11 [bug#64763] [PATCH] gnu: commencement: Use system in %final-inputs Christopher Baines
2023-08-07 15:02 ` Ludovic Courtès [this message]
2023-08-09 7:38 ` Josselin Poiret via Guix-patches via
2023-08-09 21:31 ` Ludovic Courtès
2023-08-18 14:15 ` bug#64763: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6pasxof.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=64763@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).