From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CF86MbsH0WRvbAEASxT56A (envelope-from ) for ; Mon, 07 Aug 2023 17:03:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6JHmMLsH0WTq0QAAauVa8A (envelope-from ) for ; Mon, 07 Aug 2023 17:03:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7C1634F631 for ; Mon, 7 Aug 2023 17:03:23 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=M1o3Qq+q; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691420603; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=W33LtWnjbBMKvO/codCH18RAN5o0QRkw430UwhajCb8=; b=n/YBB8M0/S+Ch4AzD5Wc8SfWVxrjxeg8aFDwSVWu0uNKFZX+37aNk8g370a78rBEGwMyE3 4W4/3XJWUG5hU1TxeWv5ZdoDwKXAfMbRN659GYpffkya/sUPLIouCgzy3OHRFg36dEtcFc xZOFsgMJQTpdVMvoTrK/rgD5Pm+aETCf38pcDZQmPsjG/eboM8/+9fTsXepmpnrTxJB7xR OY5HJ/g+Utn2taNxNxm+RqfC1/fSgflzOMgjnC5LncFMONWGRa6nbeRzZo+eUB8SzypLGb ksdq2rK3N7XH3kZapBicw9QyuifjH4ncAhKcojccJa57NlIDZO5LA48FjwBuhg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691420603; a=rsa-sha256; cv=none; b=hptzXoWWDoS/iz/uXzgS1F0+pVP3AQhGV+FoSPpXIRZPY0/wTlVqHWzF7RNcilUm5OHSkD evU7U0H29Fqdtyjy5dnPvFJPkal/72PEOIpLyLN+Nlb1/UST+Q9nNwi5uGD8NAIZloqgab XnWrkEXibVUH/4UN8hzNp0eEpxlXvxHybj3Ecyn/29mN9BUBQmzLMDlHu98E0CoyE0KCxi zSCM3dbH7JEJRFugIVDtfvx6SJEFXjBLkqH+VzLGXT9HFOTChIxYZZx/nrJ4PyYJbn3U9H w5EPLMn1LYsKZTTcdfre9xZJi+uxwUeA9RAAWZ9geRMSDqMkpJWGh5fp1Y0WQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=M1o3Qq+q; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qT1lA-0003jK-Ue; Mon, 07 Aug 2023 11:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT1l9-0003ix-3N for guix-patches@gnu.org; Mon, 07 Aug 2023 11:03:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qT1l8-0007d0-Rc for guix-patches@gnu.org; Mon, 07 Aug 2023 11:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qT1l8-0000FL-Ce for guix-patches@gnu.org; Mon, 07 Aug 2023 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64763] [PATCH] gnu: commencement: Use system in %final-inputs. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Aug 2023 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64763 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , 64763@debbugs.gnu.org Received: via spool by 64763-submit@debbugs.gnu.org id=B64763.1691420557910 (code B ref 64763); Mon, 07 Aug 2023 15:03:02 +0000 Received: (at 64763) by debbugs.gnu.org; 7 Aug 2023 15:02:37 +0000 Received: from localhost ([127.0.0.1]:34096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qT1kj-0000Ec-4H for submit@debbugs.gnu.org; Mon, 07 Aug 2023 11:02:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qT1kd-0000EM-VL for 64763@debbugs.gnu.org; Mon, 07 Aug 2023 11:02:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT1kY-0007TV-FN; Mon, 07 Aug 2023 11:02:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=W33LtWnjbBMKvO/codCH18RAN5o0QRkw430UwhajCb8=; b=M1o3Qq+qho283lnC3fnZ kMbSEqTok46Z3H5nmbIzTDpLATir+fAPekCGDmEtnLv14BxqkxzRJtDG0UmWpPHAV3/OVPDZfj/K1 b/DUUwjyHJ7FnuIzI7uFqcavYnsf4KLTQeRcVFGd9Ifj47F0adpJdrVua9YAnTj83HtQSoSelK9x/ D4n7+cZ0P0Ji+lIQPYm3kOtU69QwwXGQO8Nc5EVSukwQPnyTw0/kiXbJXJUa56b/fHuPZmGeQCbRL Dv9L4CDf1l3gjz+L9lunn82Z1LYKGXsDhXF8QRvu1Bj7q/t2+xp29uyAHDPUEsPrq39N6XR2/ig7r 8nheYaNhz3K3Qw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <3e0a5d1957c35a9925aab5600ee02b923584a599.1689934305.git.mail@cbaines.net> Date: Mon, 07 Aug 2023 17:02:24 +0200 In-Reply-To: <3e0a5d1957c35a9925aab5600ee02b923584a599.1689934305.git.mail@cbaines.net> (Christopher Baines's message of "Fri, 21 Jul 2023 11:11:45 +0100") Message-ID: <87h6pasxof.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 7C1634F631 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.86 X-Spam-Score: -6.86 X-TUID: MOtsmqbLIHcS Hi! Christopher Baines skribis: > Otherwise this causes odd issues, I presume arising from when %current-sy= stem > differs from the system argument passed to %final-inputs. > > * gnu/packages/commencement.scm (%final-inputs): Set %current-system to > system. Please add a =E2=80=9CFixes =E2=80=A6=E2=80=9D line in the log. > gnu/packages/commencement.scm | 51 ++++++++++++++++++----------------- > 1 file changed, 26 insertions(+), 25 deletions(-) > > diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm > index fe6f025257..e522e70444 100644 > --- a/gnu/packages/commencement.scm > +++ b/gnu/packages/commencement.scm > @@ -3459,31 +3459,32 @@ (define-public %final-inputs [...] > + (parameterize ((%current-system system)) LGTM! I think that was definitely the intent of 0dd293b4d9095137c9952e16ca951f887b7e7018 (Cc=E2=80=99ing Josselin just in case). Thanks, Ludo=E2=80=99. PS: I believe the reason we cannot just write: (define/system-dependent %final-inputs =E2=80=A6) is because we have two places where we do: (module-ref m '%final-inputs) which wouldn=E2=80=99t work if =E2=80=98%final-inputs=E2=80=99 were a m= acro, as is the case with =E2=80=98define/system-dependent=E2=80=99.