unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: Christopher Baines <mail@cbaines.net>, 64763@debbugs.gnu.org
Subject: [bug#64763] [PATCH] gnu: commencement: Use system in %final-inputs.
Date: Wed, 09 Aug 2023 23:31:29 +0200	[thread overview]
Message-ID: <87edkboqby.fsf@gnu.org> (raw)
In-Reply-To: <b4775df70588bbc6d63073ba019eccb73733eb26.1691566711.git.dev@jpoiret.xyz> (Josselin Poiret's message of "Wed, 9 Aug 2023 09:38:31 +0200")

Hi,

Josselin Poiret <dev@jpoiret.xyz> skribis:

> From: Christopher Baines <mail@cbaines.net>
>
> Otherwise this causes odd issues, I presume arising from when %current-system
> differs from the system argument passed to %final-inputs.
>
> * gnu/packages/commencement.scm (%final-inputs): Set %current-system to
> system.
> * gnu/packages/base.scm (%final-inputs): Add optional system parameter.
> * gnu/ci.scm (base-packages): New procedure to memoize the base packages
> depending on system.
> (package->job): Pass system to base-packages.
>
> Co-authored-by: Josselin Poiret <dev@jpoiret.xyz>
> Signed-off-by: Josselin Poiret <dev@jpoiret.xyz>

LGTM!  Great that you found the (gnu ci) issue.

Thanks,
Ludo’.




  reply	other threads:[~2023-08-09 21:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 10:11 [bug#64763] [PATCH] gnu: commencement: Use system in %final-inputs Christopher Baines
2023-08-07 15:02 ` Ludovic Courtès
2023-08-09  7:38   ` Josselin Poiret via Guix-patches via
2023-08-09 21:31     ` Ludovic Courtès [this message]
2023-08-18 14:15       ` bug#64763: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edkboqby.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=64763@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).