From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqlgf-0007GY-R0 for guix-patches@gnu.org; Sat, 09 Sep 2017 15:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqlgc-0008CN-NP for guix-patches@gnu.org; Sat, 09 Sep 2017 15:45:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqlgc-0008Ba-Jb for guix-patches@gnu.org; Sat, 09 Sep 2017 15:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dqlgc-0005sM-7t for guix-patches@gnu.org; Sat, 09 Sep 2017 15:45:02 -0400 Subject: [bug#28327] [PATCH] gnu: Add emacs-bash-completion. Resent-Message-ID: From: Alex Kost References: <20170902091112.1336-1-janneke@gnu.org> <87r2vmwb91.fsf@gmail.com> <877exb90jw.fsf@gnu.org> Date: Sat, 09 Sep 2017 22:44:17 +0300 In-Reply-To: <877exb90jw.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 06 Sep 2017 19:52:51 +0200") Message-ID: <87fubvslm6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jan Nieuwenhuizen Cc: 28327@debbugs.gnu.org Jan Nieuwenhuizen (2017-09-06 19:52 +0200) wrote: > Alex Kost writes: [...] >> You also need to patch 'bash-completion-prog' variable using >> 'emacs-substitute-variables' procedure (see (gnu packages emacs) >> module for the examples). > > I have added something here and built package works and looks okay... Now it looks OK for me as well :-) > Because adding bash to (native-)inputs already made that > 'emacs-substitute-variables' is set to bash instead of bash-minimal, I > don't really know how to test it. I see that with your patch, 'bash-completion-prog' has the value "/gnu/store/...-bash-4.4.12/bin/bash", so it is definitely 'bash' ('bash-minimal' has "/gnu/store/...-bash-minimal-4.4.12/bin/bash" name). [...] >>> + (license license:gpl3+))) >> >> I see GPL 2 or later in "bash-completion.el". > > I used guix import elpa --archive=melpa and didn't check. It seems we > cannot rely on that! We definitely shouldn't rely on it, as the importer always puts 'gpl3+': http://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/elpa.scm#n234 > New version attached, still 13 of the 30 lines were unchanged, > wow...thanks for all your helpful remarks! The patch looks good for me, thank you! -- Alex