unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Philip McGrath <philip@philipmcgrath.com>, 51853@debbugs.gnu.org
Subject: [bug#51853] [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain.
Date: Fri, 10 Dec 2021 15:15:36 +0100	[thread overview]
Message-ID: <87fsr08s1j.fsf_-_@gnu.org> (raw)
In-Reply-To: <fd47d65dd1c117d5f9a708183b88b88f1734f3e4.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 20 Nov 2021 07:54:06 +0100")

Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> Am Samstag, den 20.11.2021, 00:43 -0500 schrieb Philip McGrath:
>>  (define-public sendgmail
>>    (let ((commit "e3229155a4037267ce40f1a3a681f53221aa4d8d")
>> -        (revision "0"))
>> +        (revision "1"))
> IIRC you only need to bump revision when commit changes.  When the
> recipe itself changes, e.g. due to an added patch, I'm pretty sure the
> package would be rebuilt either way.  Can you check whether you really
> need to bump it?

I think it’s fine since functionality changed a bit; and overall, I
think it’s no reason to block the patch.

Keep in mind that the goal of patch review is to help get things in
shape so we can eventually apply them (the sooner the better).  Don’t
hesitate to apply patches that are ready or ready minus details that you
can fix yourself.

Thanks for reviewing!

Ludo’.




      reply	other threads:[~2021-12-10 14:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 20:36 [bug#51853] [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain Philip McGrath
2021-11-14 20:46 ` [bug#51853] [PATCH 1/2] gnu: sendgmail: Rename package to match command Philip McGrath
2021-11-14 20:46   ` [bug#51853] [PATCH 2/2] gnu: sendgmail: Don't limit domain name of sender Philip McGrath
2021-11-17 17:24   ` [bug#51853] [PATCH 1/2] gnu: sendgmail: Rename package to match command Liliana Marie Prikler
2021-11-20  5:43     ` [bug#51853] [PATCH v2 0/2] gnu: sendgmail: Rename package; don't limit domain Philip McGrath
2021-11-20  5:43       ` [bug#51853] [PATCH v2 1/2] gnu: sendgmail: Rename package to match command Philip McGrath
2021-12-10 14:12         ` bug#51853: [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain Ludovic Courtès
2021-11-20  5:43       ` [bug#51853] [PATCH v2 2/2] gnu: sendgmail: Don't limit domain name of sender Philip McGrath
2021-11-20  6:54         ` Liliana Marie Prikler
2021-12-10 14:15           ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsr08s1j.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=51853@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=philip@philipmcgrath.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).