From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Philip McGrath <philip@philipmcgrath.com>, 51853@debbugs.gnu.org
Subject: [bug#51853] [PATCH v2 2/2] gnu: sendgmail: Don't limit domain name of sender.
Date: Sat, 20 Nov 2021 07:54:06 +0100 [thread overview]
Message-ID: <fd47d65dd1c117d5f9a708183b88b88f1734f3e4.camel@gmail.com> (raw)
In-Reply-To: <20211120054353.987243-3-philip@philipmcgrath.com>
Hi,
Am Samstag, den 20.11.2021, 00:43 -0500 schrieb Philip McGrath:
> (define-public sendgmail
> (let ((commit "e3229155a4037267ce40f1a3a681f53221aa4d8d")
> - (revision "0"))
> + (revision "1"))
IIRC you only need to bump revision when commit changes. When the
recipe itself changes, e.g. due to an added patch, I'm pretty sure the
package would be rebuilt either way. Can you check whether you really
need to bump it?
> (package
> (name "sendgmail")
> (version (git-version "0.0.0" revision commit))
> @@ -4657,6 +4657,9 @@ (define-public sendgmail
> (url "https://github.com/google/gmail-oauth2-tools")
> (commit commit)))
> (file-name (git-file-name name version))
> + (patches (search-patches
> + "sendgmail-remove-domain-restriction.patch"
> + "sendgmail-accept-ignored-gsuite-flag.patch"))
> (sha256
> (base32
> "1cxpkiaajhq1gjsg47r2b5xgck0r63pvkyrkm7af8c8dw7fyn64f")))
> )
> @@ -4676,5 +4679,9 @@ (define-public sendgmail
> "The @command{sendgmail} command provides a minimal sendmail-
> compatible
> front-end that connects to Gmail using OAuth2. It is specifically
> designed
> for use with @code{git send-email}. The command needs a Gmail API
> key to
> -function.")
> +function.
> +
> +Guix's version of @command{sendgmail} has been patched for
> compatibility with
> +all known forks, including support for non-@code{@@gmail.com} email
> +addresses.")
Funnily enough non-@code is highlighted as a mail address for me. It's
not high priority, but you might want to rewrite that sentence to
convey the same information in a way that @code is not preceded by
anything.
Cheers
next prev parent reply other threads:[~2021-11-20 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 20:36 [bug#51853] [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain Philip McGrath
2021-11-14 20:46 ` [bug#51853] [PATCH 1/2] gnu: sendgmail: Rename package to match command Philip McGrath
2021-11-14 20:46 ` [bug#51853] [PATCH 2/2] gnu: sendgmail: Don't limit domain name of sender Philip McGrath
2021-11-17 17:24 ` [bug#51853] [PATCH 1/2] gnu: sendgmail: Rename package to match command Liliana Marie Prikler
2021-11-20 5:43 ` [bug#51853] [PATCH v2 0/2] gnu: sendgmail: Rename package; don't limit domain Philip McGrath
2021-11-20 5:43 ` [bug#51853] [PATCH v2 1/2] gnu: sendgmail: Rename package to match command Philip McGrath
2021-12-10 14:12 ` bug#51853: [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain Ludovic Courtès
2021-11-20 5:43 ` [bug#51853] [PATCH v2 2/2] gnu: sendgmail: Don't limit domain name of sender Philip McGrath
2021-11-20 6:54 ` Liliana Marie Prikler [this message]
2021-12-10 14:15 ` [bug#51853] [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd47d65dd1c117d5f9a708183b88b88f1734f3e4.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=51853@debbugs.gnu.org \
--cc=philip@philipmcgrath.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).