From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cLtsIS9hs2HyfgEAgWs5BA (envelope-from ) for ; Fri, 10 Dec 2021 15:16:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mET3HC9hs2FnNgAAbx9fmQ (envelope-from ) for ; Fri, 10 Dec 2021 14:16:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E52235EAD for ; Fri, 10 Dec 2021 15:16:15 +0100 (CET) Received: from localhost ([::1]:34788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvgh4-0004zT-DF for larch@yhetil.org; Fri, 10 Dec 2021 09:16:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvggs-0004yq-Bm for guix-patches@gnu.org; Fri, 10 Dec 2021 09:16:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvggs-0000Do-1c for guix-patches@gnu.org; Fri, 10 Dec 2021 09:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mvggr-0000hI-MP for guix-patches@gnu.org; Fri, 10 Dec 2021 09:16:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51853] [PATCH 0/2] gnu: sendgmail: Rename package; don't limit domain. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Dec 2021 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51853 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Philip McGrath , 51853@debbugs.gnu.org Received: via spool by 51853-submit@debbugs.gnu.org id=B51853.16391457462656 (code B ref 51853); Fri, 10 Dec 2021 14:16:01 +0000 Received: (at 51853) by debbugs.gnu.org; 10 Dec 2021 14:15:46 +0000 Received: from localhost ([127.0.0.1]:45991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvggb-0000gm-Rt for submit@debbugs.gnu.org; Fri, 10 Dec 2021 09:15:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvgga-0000gT-0C for 51853@debbugs.gnu.org; Fri, 10 Dec 2021 09:15:44 -0500 Received: from [2001:470:142:3::e] (port=53606 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvggU-0008Vv-Ph; Fri, 10 Dec 2021 09:15:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=yDx8RZzwn1ffJQRq3x2Svrdmysg5otBKaSZvtConHaM=; b=HFaACqixBT5iy5V/On8F JHzzuuu4YvPmqzShMrgmoPBrHu6rhljMU3POkoUUcSAJQ/To+kYmXkX2x/zid2lb/iRqQILXHyBda wx9QimXYXWVlUP2Ybl8G3j5Y2s2uYt5T7nzbgtY3pOSzBG+ARp93NrZRlTsSmAUF5rdyM6bgqN+sh LZGDXaBNb4sPnnqKijtJNUBO/VpOpVnPNHoC/l6Kjvm2bz2ZoH/CJXX5HO8pcwAwLPUdghm/46uLR QnPKhyMo+P3rNszTc1t5D7o2+c6pME18+N634isg0pFWIgb4qzoDBhjHKDV8yR2zvfQhVOlSg0bKB 1I5vd48H69CTtw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57771 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvggU-0003nv-N5; Fri, 10 Dec 2021 09:15:38 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <077cf4ed09eab394f74bb87600e7442525143a53.camel@gmail.com> <20211120054353.987243-1-philip@philipmcgrath.com> <20211120054353.987243-3-philip@philipmcgrath.com> Date: Fri, 10 Dec 2021 15:15:36 +0100 In-Reply-To: (Liliana Marie Prikler's message of "Sat, 20 Nov 2021 07:54:06 +0100") Message-ID: <87fsr08s1j.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639145775; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yDx8RZzwn1ffJQRq3x2Svrdmysg5otBKaSZvtConHaM=; b=K1+SpmUy8nQXPpJKQJdWqCnlWbSogrdo18xq3i175Q4cTeRjCL8b1oRtzsnwzE1qCDl9mi i6BZVHabzhJABUZsHpMtuhA5FoaXyUBj2xjHPBR5jtodw0hXNloO9Is1Ba6ninvkyzXScT QSWuhPVP2ITtWRA2Hei3MNCsKVsgpiCEYF0wltw3c4ZsKJEFBRy3Oc5mQC+cB25pFFoiTd RzcPqw3y5T+Hffr6WkbwC6U/wPgO3TKCoyMG/HtQEY3/Q5UxvVmapBXpbvLNnsIRKg3ukW avcbDNXHHR9ala9KyUB3brv3oLerwhGnmW6VojNzOxVoHrllPLqhZSFuLgW9dQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639145775; a=rsa-sha256; cv=none; b=HFUaUC5r/O7vfHfdyyH9dg3x6QHfVQUZxcrMde/gSsYtP/n+8zuaMFHmZV4fviko6vx41p Ywe2i2502im27b3kyqxDTayX7zmh0GWWi6d8GXD/Ao2WL6mcN4mCzSKzvmv5WJonm/l7x5 l4508PSsHHUKG4Gl8HlCqqNNynZef1ZGoLb2iQyOvL4qKd09pN0DeslisxBy11Hc+Y+KP9 plL9ljQyOMNZp0sLBGZesOnaMoW8P8gx4i6+cyaCrly/ZogLyRbBBT0xEP4nBo/BzvmqKp W7lq6mRIf9YHjC+iUn44KcKdRVv2gI4Y/v1hFaWH3cRqRlEgE+T5MfJc9ZOopQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HFaACqix; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HFaACqix; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4E52235EAD X-Spam-Score: -3.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: KCJJvHu2RZZj Hi Liliana, Liliana Marie Prikler skribis: > Am Samstag, den 20.11.2021, 00:43 -0500 schrieb Philip McGrath: >> (define-public sendgmail >> (let ((commit "e3229155a4037267ce40f1a3a681f53221aa4d8d") >> - (revision "0")) >> + (revision "1")) > IIRC you only need to bump revision when commit changes. When the > recipe itself changes, e.g. due to an added patch, I'm pretty sure the > package would be rebuilt either way. Can you check whether you really > need to bump it? I think it=E2=80=99s fine since functionality changed a bit; and overall, I think it=E2=80=99s no reason to block the patch. Keep in mind that the goal of patch review is to help get things in shape so we can eventually apply them (the sooner the better). Don=E2=80= =99t hesitate to apply patches that are ready or ready minus details that you can fix yourself. Thanks for reviewing! Ludo=E2=80=99.