From: Marius Bakke <mbakke@fastmail.com>
To: Julien Lepiller <julien@lepiller.eu>, 28285@debbugs.gnu.org
Subject: [bug#28285] Add heimdall
Date: Wed, 30 Aug 2017 21:25:51 +0200 [thread overview]
Message-ID: <87d17cluww.fsf@fastmail.com> (raw)
In-Reply-To: <20170829235829.7a4f55cd@lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]
Julien Lepiller <julien@lepiller.eu> writes:
> Hi,
>
> this patch adds heimdall, a tool I just used to flash replicant on my
> smartphone :)
Cool!
> * gnu/packages/android.scm (heimdall): New variable.
I agree with Jonathan that 'flashing-tools.scm' is better suited.
[...]
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (mkdir-p bin)
> + (copy-file "bin/heimdall" (string-append bin "/heimdall"))
> + (copy-file "bin/heimdall-frontend"
> + (string-append bin "/heimdall-frontend"))))))))
(copy-file ...) has an unspecified return value[0], so please add a #t
at the end of this phase for determinism.
> + (inputs
> + `(("libusb" ,libusb)
> + ("qt" ,qt)
Can you try to use the modular qt packages here (qtbase and friends),
instead of the 'qt' monolith? The latter is not well maintained and
will be removed eventually.
> + ("zlib" ,zlib)))
> + (home-page "http://glassechidna.com.au/heimdall/")
> + (synopsis "Flash firmware onto Samsung mobile devices")
> + (description "Heimdall is a tool suite used to flash firmware (aka ROMs)
> +onto Samsung mobile devices. Heimdall connects to a mobile device over USB and
> +interacts with low-level software running on the device, known as Loke. Loke
> +and Heimdall communicate via the custom Samsung-developed protocol typically
> +referred to as the 'Odin 3 protocol'.")
`guix lint` should complain about the single quotes, no? Escaped double
quotes are okay, though.
LGTM with these cosmetic changes.
[0] https://www.gnu.org/software/guile/manual/guile.html#File-System
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-08-30 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 21:58 [bug#28285] Add heimdall Julien Lepiller
2017-08-30 8:13 ` Jonathan Brielmaier
2017-08-30 19:25 ` Marius Bakke [this message]
2017-09-03 16:53 ` Julien Lepiller
2017-09-04 14:22 ` Ludovic Courtès
2017-09-08 12:41 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d17cluww.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=28285@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).