From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn8co-0005Kt-Sa for guix-patches@gnu.org; Wed, 30 Aug 2017 15:26:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn8ck-0002Je-BQ for guix-patches@gnu.org; Wed, 30 Aug 2017 15:26:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dn8ck-0002JX-37 for guix-patches@gnu.org; Wed, 30 Aug 2017 15:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dn8cj-0005xf-TS for guix-patches@gnu.org; Wed, 30 Aug 2017 15:26:01 -0400 Subject: [bug#28285] Add heimdall Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170829235829.7a4f55cd@lepiller.eu> References: <20170829235829.7a4f55cd@lepiller.eu> Date: Wed, 30 Aug 2017 21:25:51 +0200 Message-ID: <87d17cluww.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller , 28285@debbugs.gnu.org --=-=-= Content-Type: text/plain Julien Lepiller writes: > Hi, > > this patch adds heimdall, a tool I just used to flash replicant on my > smartphone :) Cool! > * gnu/packages/android.scm (heimdall): New variable. I agree with Jonathan that 'flashing-tools.scm' is better suited. [...] > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) > + (mkdir-p bin) > + (copy-file "bin/heimdall" (string-append bin "/heimdall")) > + (copy-file "bin/heimdall-frontend" > + (string-append bin "/heimdall-frontend")))))))) (copy-file ...) has an unspecified return value[0], so please add a #t at the end of this phase for determinism. > + (inputs > + `(("libusb" ,libusb) > + ("qt" ,qt) Can you try to use the modular qt packages here (qtbase and friends), instead of the 'qt' monolith? The latter is not well maintained and will be removed eventually. > + ("zlib" ,zlib))) > + (home-page "http://glassechidna.com.au/heimdall/") > + (synopsis "Flash firmware onto Samsung mobile devices") > + (description "Heimdall is a tool suite used to flash firmware (aka ROMs) > +onto Samsung mobile devices. Heimdall connects to a mobile device over USB and > +interacts with low-level software running on the device, known as Loke. Loke > +and Heimdall communicate via the custom Samsung-developed protocol typically > +referred to as the 'Odin 3 protocol'.") `guix lint` should complain about the single quotes, no? Escaped double quotes are okay, though. LGTM with these cosmetic changes. [0] https://www.gnu.org/software/guile/manual/guile.html#File-System --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmnET8ACgkQoqBt8qM6 VPqQkQgAt5Rmtyc8ZpcSJZUIpUuZ3EMyd5D6vkLNd/ke88UD+Tt0Krt4SwUxhDTu 22KTVzwdBEs0HlJw30FOGdY1m42G79ee658GTYqk4R5GAaNPOJjB/bJ9YXp3Q0VA b0IZdRq/AmKCyl1JKeVRmnrasnRHI6LiCsY3686I4boW8Yu4JHi3xl6NzjSPOe92 WuFBjR6o/BVJIk/m/u5cRoYgfRThqKxHQ9fbz/FqtIrkEUxDTSX4+GUnbB+rQ4mn lilOoGtA20usMJq/jOZMaZRY0rJAqOn2u01wUEt8/tY6PtOiC1730Em/OssCuavO em+chLiGc/QgYFVJr7Q/dul5WhyrZQ== =5ebQ -----END PGP SIGNATURE----- --=-=-=--