From: ludo@gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien@lepiller.eu>
Cc: 28285@debbugs.gnu.org
Subject: [bug#28285] Add heimdall
Date: Mon, 04 Sep 2017 16:22:55 +0200 [thread overview]
Message-ID: <87wp5ezgow.fsf@gnu.org> (raw)
In-Reply-To: <20170903185259.4c056094@lepiller.eu> (Julien Lepiller's message of "Sun, 3 Sep 2017 18:53:06 +0200")
Hello,
Julien Lepiller <julien@lepiller.eu> skribis:
> I had to change the import of licenses and license field of all
> packages because heimdall depends on zlib, which is also a license
> name. Should I mention that in the commit message too? Should it be in
> a separate commit?
IMO it’s marginely better as a separate commit, but no big deal.
> From 77a0831ce91b61eca537d197e9c15720b3b6cf7e Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
>
> * gnu/packages/flashing-tools.scm (heimdall): New variable.
[...]
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (mkdir-p bin)
> + (copy-file "bin/heimdall" (string-append bin "/heimdall"))
> + (copy-file "bin/heimdall-frontend"
> + (string-append bin "/heimdall-frontend"))
You can write these as:
(install-file "bin/heimdall" bin)
…
and also remove (mkdir-p bin).
OK with these changes!
Ludo’.
next prev parent reply other threads:[~2017-09-04 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 21:58 [bug#28285] Add heimdall Julien Lepiller
2017-08-30 8:13 ` Jonathan Brielmaier
2017-08-30 19:25 ` Marius Bakke
2017-09-03 16:53 ` Julien Lepiller
2017-09-04 14:22 ` Ludovic Courtès [this message]
2017-09-08 12:41 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp5ezgow.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28285@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).