David Wilson writes: > Marius Bakke writes: > >> It is definitively OK to disable warnings coming from dependencies. In >> fact, that is what we are supposed to do, and used to do until the >> switch to GCC 7. >> >> To clarify, when we switched to GCC 7, its search paths were changed >> from C{,PLUS}_INCLUDE_PATH to CPATH. The only[*] difference between >> these search paths is that headers found on the former are treated as >> "system headers", which disables warnings. >> >> [*] Besides the fact that GCC 6 and later is very picky about the order >> of entries in C_INCLUDE_PATH, which is why we had to switch; see >> for details. > > Thanks for the background, that was helpful! I've been out of the loop > on GCC changes for a while so it's good to know that this happened. > > I've made the suggested changes to the summary and description, attached > the updated patch. Excellent, LGTM!