From: "Ludovic Courtès" <ludo@gnu.org>
To: Felix Gruber <felgru@posteo.net>
Cc: 39862@debbugs.gnu.org
Subject: [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages
Date: Fri, 13 Mar 2020 22:28:11 +0100 [thread overview]
Message-ID: <87d09gndw4.fsf@gnu.org> (raw)
In-Reply-To: <fc5a653b-d07e-3aea-d16e-fa654e1b6ece@posteo.net> (Felix Gruber's message of "Fri, 13 Mar 2020 18:26:11 +0100")
Hi,
Felix Gruber <felgru@posteo.net> skribis:
>>> + (lambda (p) (not (dune-package? p))))))
>>
>> You can replace the lambda with:
>>
>> (negate dune-package?)
>
> Thanks for this hint, as I'm new to Scheme, my knowledge of its standard
> library is still pretty limited.
Sure, I think sharing knowledge is one of the goals of review.
>> One last thing: could you look at the output of, say, ‘guix graph
>> dune-geometry-openmpi’ and ensure we’re not duplicating more nodes than
>> needed in the graph?
>>
>> For example, you can compare node counts with:
>>
>> guix graph dune-geometry | grep 'label =' | wc -l
>> guix graph dune-geometry-openmpi | grep 'label =' | wc -l
>>
>> The difference should be less than:
>>
>> guix graph openmpi | grep 'label =' | wc -l
>>
>> If that works well, please send an updated patch and we should be ready
>> to go!
>
> I get the following numbers:
>
> graph dune-geometry | grep 'label =' | wc -l
> 70
>
> guix graph dune-geometry-openmpi | grep 'label =' | wc -l
> 143
>
> guix graph openmpi | grep 'label =' | wc -l
> 137
>
> The difference seems to be OK: 143 - 70 = 73 < 137.
Looks good, thanks!
Ludo’.
next prev parent reply other threads:[~2020-03-13 21:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 19:49 [bug#39862] [PATCH 0/4] update Dune finite element packages Felix Gruber
2020-03-01 20:23 ` [bug#39862] [PATCH 1/4] gnu: dune-*: set up MPI for tests Felix Gruber
2020-03-01 20:24 ` [bug#39862] [PATCH 2/4] gnu: add dune-uggrid 2.6.0 Felix Gruber
2020-03-01 20:25 ` [bug#39862] [PATCH 3/4] gnu: Add dune-subgrid Felix Gruber
2020-03-01 20:25 ` [bug#39862] [PATCH 4/4] gnu: dune-istl: Build with suitesparse Felix Gruber
2020-03-02 14:53 ` [bug#39862] [PATCH 0/4] update Dune finite element packages zimoun
2020-03-02 21:56 ` Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 0/6] Update " Felix Gruber
2020-03-12 10:46 ` Ludovic Courtès
2020-03-10 19:29 ` [bug#39862] [PATCH v2 1/6] gnu: dune-*: set up MPI for tests Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 2/6] gnu: add dune-uggrid 2.6.0 Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 3/6] gnu: Add dune-subgrid Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 4/6] gnu: dune-istl: Build with suitesparse Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 5/6] gnu: dune-*: remove openmpi dependency Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 6/6] gnu: define dune-*-openmpi packages Felix Gruber
2020-03-12 12:42 ` Ludovic Courtès
2020-03-12 21:05 ` [bug#39862] [PATCH v3 0/2] Add " Felix Gruber
2020-03-12 21:05 ` [bug#39862] [PATCH v3 1/2] gnu: dune-*: remove openmpi dependency Felix Gruber
2020-03-12 21:05 ` [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages Felix Gruber
2020-03-13 9:42 ` Ludovic Courtès
2020-03-13 17:26 ` Felix Gruber
2020-03-13 21:28 ` Ludovic Courtès [this message]
2020-03-13 17:30 ` [bug#39862] [PATCH v4 1/2] gnu: dune-*: remove openmpi dependency Felix Gruber
2020-03-14 16:55 ` bug#39862: " Ludovic Courtès
2020-03-13 17:30 ` [bug#39862] [PATCH v4 2/2] gnu: define dune-*-openmpi packages Felix Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09gndw4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39862@debbugs.gnu.org \
--cc=felgru@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).