From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53459)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jCrrb-0000Pc-7N
 for guix-patches@gnu.org; Fri, 13 Mar 2020 17:29:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jCrra-0002l0-96
 for guix-patches@gnu.org; Fri, 13 Mar 2020 17:29:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:54326)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jCrra-0002kA-4q
 for guix-patches@gnu.org; Fri, 13 Mar 2020 17:29:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jCrra-0007TT-0z
 for guix-patches@gnu.org; Fri, 13 Mar 2020 17:29:02 -0400
Subject: [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages
Resent-Message-ID: <handler.39862.B39862.158413490828691@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87k13pvj5u.fsf@gnu.org>
 <20200312210513.107891-3-felgru@posteo.net> <87blp0pp4d.fsf@gnu.org>
 <fc5a653b-d07e-3aea-d16e-fa654e1b6ece@posteo.net>
Date: Fri, 13 Mar 2020 22:28:11 +0100
In-Reply-To: <fc5a653b-d07e-3aea-d16e-fa654e1b6ece@posteo.net> (Felix Gruber's
 message of "Fri, 13 Mar 2020 18:26:11 +0100")
Message-ID: <87d09gndw4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Felix Gruber <felgru@posteo.net>
Cc: 39862@debbugs.gnu.org

Hi,

Felix Gruber <felgru@posteo.net> skribis:

>>> +      (lambda (p) (not (dune-package? p))))))
>>=20
>> You can replace the lambda with:
>>=20
>>   (negate dune-package?)
>
> Thanks for this hint, as I'm new to Scheme, my knowledge of its standard
> library is still pretty limited.

Sure, I think sharing knowledge is one of the goals of review.

>> One last thing: could you look at the output of, say, =E2=80=98guix graph
>> dune-geometry-openmpi=E2=80=99 and ensure we=E2=80=99re not duplicating =
more nodes than
>> needed in the graph?
>>=20
>> For example, you can compare node counts with:
>>=20
>>   guix graph dune-geometry | grep 'label =3D' | wc -l
>>   guix graph dune-geometry-openmpi | grep 'label =3D' | wc -l
>>=20
>> The difference should be less than:
>>=20
>>   guix graph openmpi | grep 'label =3D' | wc -l
>>=20
>> If that works well, please send an updated patch and we should be ready
>> to go!
>
> I get the following numbers:
>
>  graph dune-geometry | grep 'label =3D' | wc -l
>  70
>
>  guix graph dune-geometry-openmpi | grep 'label =3D' | wc -l
>  143
>
>  guix graph openmpi | grep 'label =3D' | wc -l
>  137
>
> The difference seems to be OK: 143 - 70 =3D 73 < 137.

Looks good, thanks!

Ludo=E2=80=99.