From: "Ludovic Courtès" <ludo@gnu.org>
To: Felix Gruber <felgru@posteo.net>
Cc: zimoun <zimon.toutoune@gmail.com>, 39862@debbugs.gnu.org
Subject: [bug#39862] [PATCH v2 6/6] gnu: define dune-*-openmpi packages
Date: Thu, 12 Mar 2020 13:42:37 +0100 [thread overview]
Message-ID: <87k13pvj5u.fsf@gnu.org> (raw)
In-Reply-To: <20200310192910.6251-7-felgru@posteo.net> (Felix Gruber's message of "Tue, 10 Mar 2020 20:29:10 +0100")
Hi again,
Felix Gruber <felgru@posteo.net> skribis:
> +(define add-openmpi-to-dune-package
> + (let ((transformed-packages '()))
> + (lambda (p)
> + (let* ((p-name (package-name p))
> + (replace-package
> + (lambda (mapping)
> + (let* ((name (car mapping))
> + (p (cadr mapping))
> + (new-p
> + (match (assoc-ref transformed-packages name)
> + (#f
> + (if (string-prefix? "dune-" name)
> + (raise (condition
> + (&message
> + (message
> + (format #f "Need to call \
> +add-openmpi-to-dune-package on '~a' before '~a'."
> + name p-name)))))
> + p))
> + (transformed-p transformed-p))))
> + `(,name ,new-p))))
> + (substitute-mpi-packages (lambda (inputs)
> + (map replace-package inputs)))
> + (mpi-p
> + (package (inherit p)
> + (name (string-append p-name "-openmpi"))
> + (inputs `(,@(substitute-mpi-packages (package-inputs p))
> + ("openmpi" ,openmpi)))
> + (propagated-inputs
> + (substitute-mpi-packages (package-propagated-inputs p)))
> + (arguments
> + (substitute-keyword-arguments (package-arguments p)
> + ((#:phases phases '%standard-phases)
> + `(modify-phases ,phases
> + (add-before 'check 'mpi-setup
> + ,%openmpi-setup)))))
> + (synopsis (string-append (package-synopsis p) " (with MPI support)")))))
> + (begin
> + (set! transformed-packages
> + (acons p-name mpi-p transformed-packages))
> + mpi-p)))))
I think it’s a good idea to add those “-openmpi” packages. However, I
have suggestions regarding the code above. :-)
A general note: set!, car, cdr, etc. are frowned upon in Guix:
https://guix.gnu.org/manual/en/html_node/Coding-Style.html
It seems to me that ‘replace-package’ above is overly generic: since
it’s an internal procedure, we don’t need to add error cases, messages,
etc.
Last, could it be written in terms of ‘package-mapping’? That takes
care of graph traversal and memoization.
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-03-12 12:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 19:49 [bug#39862] [PATCH 0/4] update Dune finite element packages Felix Gruber
2020-03-01 20:23 ` [bug#39862] [PATCH 1/4] gnu: dune-*: set up MPI for tests Felix Gruber
2020-03-01 20:24 ` [bug#39862] [PATCH 2/4] gnu: add dune-uggrid 2.6.0 Felix Gruber
2020-03-01 20:25 ` [bug#39862] [PATCH 3/4] gnu: Add dune-subgrid Felix Gruber
2020-03-01 20:25 ` [bug#39862] [PATCH 4/4] gnu: dune-istl: Build with suitesparse Felix Gruber
2020-03-02 14:53 ` [bug#39862] [PATCH 0/4] update Dune finite element packages zimoun
2020-03-02 21:56 ` Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 0/6] Update " Felix Gruber
2020-03-12 10:46 ` Ludovic Courtès
2020-03-10 19:29 ` [bug#39862] [PATCH v2 1/6] gnu: dune-*: set up MPI for tests Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 2/6] gnu: add dune-uggrid 2.6.0 Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 3/6] gnu: Add dune-subgrid Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 4/6] gnu: dune-istl: Build with suitesparse Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 5/6] gnu: dune-*: remove openmpi dependency Felix Gruber
2020-03-10 19:29 ` [bug#39862] [PATCH v2 6/6] gnu: define dune-*-openmpi packages Felix Gruber
2020-03-12 12:42 ` Ludovic Courtès [this message]
2020-03-12 21:05 ` [bug#39862] [PATCH v3 0/2] Add " Felix Gruber
2020-03-12 21:05 ` [bug#39862] [PATCH v3 1/2] gnu: dune-*: remove openmpi dependency Felix Gruber
2020-03-12 21:05 ` [bug#39862] [PATCH v3 2/2] gnu: define dune-*-openmpi packages Felix Gruber
2020-03-13 9:42 ` Ludovic Courtès
2020-03-13 17:26 ` Felix Gruber
2020-03-13 21:28 ` Ludovic Courtès
2020-03-13 17:30 ` [bug#39862] [PATCH v4 1/2] gnu: dune-*: remove openmpi dependency Felix Gruber
2020-03-14 16:55 ` bug#39862: " Ludovic Courtès
2020-03-13 17:30 ` [bug#39862] [PATCH v4 2/2] gnu: define dune-*-openmpi packages Felix Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k13pvj5u.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39862@debbugs.gnu.org \
--cc=felgru@posteo.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).