unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 46823@debbugs.gnu.org
Cc: lle-bout@zaclys.net
Subject: [bug#46823] [PATCH 1/3] gnu: Add python-readability.
Date: Fri, 05 Mar 2021 17:32:42 +0100	[thread overview]
Message-ID: <87czwdef2t.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <14e0b89e446e222d9b4cf40eeb5fbdbbdc0576e6.camel@zaclys.net> ("Léo Le Bouter via Guix-patches via"'s message of "Sat, 27 Feb 2021 23:42:53 +0100")

Hello,

Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> writes:

> If I do not wrap XDG_DATA_DIRS, then in a --pure environment gfeeds
> cannot find gsettings-desktop-schemas and wont start.

It looks like a common deed across packages.

> I also figured I'd depend on mpv and specify it's full path in the
> config by default (instead of just the PATH's relative "mpv") since it
> is useful for basic functionality of the software (rss on feeds
> providing video links). Depending on the user's profile, the user is
> still free to change it. Does that sound OK to you?

It is better than propagating it anyway. I think that's fine.

Note that (native-)inputs should be sorted alphabetically, and
descriptions ought to be full sentences.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-03-05 16:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27 22:34 [bug#46823] [PATCH 1/3] gnu: Add python-readability Léo Le Bouter via Guix-patches via
2021-02-27 22:36 ` [bug#46823] [PATCH 2/3] gnu: Add python-listparser Léo Le Bouter via Guix-patches via
2021-02-27 22:36   ` [bug#46823] [PATCH 3/3] gnu: Add gfeeds Léo Le Bouter via Guix-patches via
2021-02-27 22:42 ` [bug#46823] [PATCH 1/3] gnu: Add python-readability Léo Le Bouter via Guix-patches via
2021-03-05 16:32   ` Nicolas Goaziou [this message]
2021-03-05 23:19     ` Léo Le Bouter via Guix-patches via
2021-03-06 10:13       ` Nicolas Goaziou
2021-03-06 17:44         ` Léo Le Bouter via Guix-patches via
2021-03-08  9:16           ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czwdef2t.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=46823@debbugs.gnu.org \
    --cc=lle-bout@zaclys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).