unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Léo Le Bouter via Guix-patches via" <guix-patches@gnu.org>
To: mail@nicolasgoaziou.fr, 46823@debbugs.gnu.org
Cc: 46823-done@debbugs.gnu.org
Subject: [bug#46823] [PATCH 1/3] gnu: Add python-readability.
Date: Sat, 06 Mar 2021 00:19:46 +0100	[thread overview]
Message-ID: <37b77e5fee4340e717ef8a1105e2dd6d6ac2aa26.camel@zaclys.net> (raw)
In-Reply-To: <87czwdef2t.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On Fri, 2021-03-05 at 17:32 +0100, Nicolas Goaziou wrote:

Thanks for the review!

> Note that (native-)inputs should be sorted alphabetically, and
> descriptions ought to be full sentences.

I did the descriptions but did not sort all *inputs because it is quite
troublesome to do so editing commit history etc.. I don't like doing it
manually and don't have any tooling, also don't think it is very
worthwhile use of my time, nor do I think it adds much value to GNU
Guix. If you have any tooling to suggest to do it easily in Emacs then
I'll happily do that in every of my contributions by default.

I also moved gfeeds to gnu/packages/syndication.scm as that's where it
sits better I think, it not being an official GNOME project.

Pushed all in 373e5fc96724fd38bb1263e4af90932ea36f596b.

Léo

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-05 23:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27 22:34 [bug#46823] [PATCH 1/3] gnu: Add python-readability Léo Le Bouter via Guix-patches via
2021-02-27 22:36 ` [bug#46823] [PATCH 2/3] gnu: Add python-listparser Léo Le Bouter via Guix-patches via
2021-02-27 22:36   ` [bug#46823] [PATCH 3/3] gnu: Add gfeeds Léo Le Bouter via Guix-patches via
2021-02-27 22:42 ` [bug#46823] [PATCH 1/3] gnu: Add python-readability Léo Le Bouter via Guix-patches via
2021-03-05 16:32   ` Nicolas Goaziou
2021-03-05 23:19     ` Léo Le Bouter via Guix-patches via [this message]
2021-03-06 10:13       ` Nicolas Goaziou
2021-03-06 17:44         ` Léo Le Bouter via Guix-patches via
2021-03-08  9:16           ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37b77e5fee4340e717ef8a1105e2dd6d6ac2aa26.camel@zaclys.net \
    --to=guix-patches@gnu.org \
    --cc=46823-done@debbugs.gnu.org \
    --cc=46823@debbugs.gnu.org \
    --cc=lle-bout@zaclys.net \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).