unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Léo Le Bouter" <lle-bout@zaclys.net>,
	"Nicolas Goaziou" <mail@nicolasgoaziou.fr>
Cc: 46823-done@debbugs.gnu.org
Subject: [bug#46823] [PATCH 1/3] gnu: Add python-readability.
Date: Mon, 08 Mar 2021 10:16:21 +0100	[thread overview]
Message-ID: <865z2280pm.fsf@gmail.com> (raw)
In-Reply-To: <84123b4698fce44aa18e100a6020c58103c43594.camel@zaclys.net>

Hi,

On Sat, 06 Mar 2021 at 18:44, Léo Le Bouter via Guix-patches via <guix-patches@gnu.org> wrote:
> On Sat, 2021-03-06 at 11:13 +0100, Nicolas Goaziou wrote:

>> However, sorting inputs alphabetically has some value. For example,
>> it
>> makes it easier to add more inputs later, as it becomes less tedious
>> to
>> check for duplicates.
>
> Agreed but seeing all that has to be done in GNU Guix.. we can
> massively sort *-inputs another time can't we? Or if there's an
> automated pre-commit hook or Emacs "guix-packageer-mode" someone can
> make, I'll happily install it.

I am not convinced tooling for sorting inputs is worth here.  I mean
sorting the inputs (if there are not) or keeping sorted the inputs list
is so quick and easy compared to other parts of the packaging that
sorting is more a discipline than a concrete issue, similarly as two
spaces for the description’s sentences.  IMHO.

However, “guix lint” could warn when the inputs are not sorted.

And it remembers me this bug report:

<http://issues.guix.gnu.org/issue/42289>


Cheers,
simon




      reply	other threads:[~2021-03-08  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27 22:34 [bug#46823] [PATCH 1/3] gnu: Add python-readability Léo Le Bouter via Guix-patches via
2021-02-27 22:36 ` [bug#46823] [PATCH 2/3] gnu: Add python-listparser Léo Le Bouter via Guix-patches via
2021-02-27 22:36   ` [bug#46823] [PATCH 3/3] gnu: Add gfeeds Léo Le Bouter via Guix-patches via
2021-02-27 22:42 ` [bug#46823] [PATCH 1/3] gnu: Add python-readability Léo Le Bouter via Guix-patches via
2021-03-05 16:32   ` Nicolas Goaziou
2021-03-05 23:19     ` Léo Le Bouter via Guix-patches via
2021-03-06 10:13       ` Nicolas Goaziou
2021-03-06 17:44         ` Léo Le Bouter via Guix-patches via
2021-03-08  9:16           ` zimoun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865z2280pm.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=46823-done@debbugs.gnu.org \
    --cc=lle-bout@zaclys.net \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).