From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Mike Delago <michaeldelago98@gmail.com>
Cc: 68569@debbugs.gnu.org
Subject: [bug#68569] [PATCH 1/2] gnu: Add python-apprise.
Date: Sat, 20 Jan 2024 23:57:08 -0500 [thread overview]
Message-ID: <87cytvb7x7.fsf@gmail.com> (raw)
In-Reply-To: <236d62db2eb224c0ae8ee7ea0fabecbb4dc4c929.1705586561.git.michaeldelago98@gmail.com> (Mike Delago's message of "Thu, 18 Jan 2024 09:32:07 -0500")
Hi!
Mike Delago <michaeldelago98@gmail.com> writes:
> * gnu/packages/python-xyz.scm (python-apprise): New variable.
>
> Change-Id: I24659780121e3d428002f504a459bea442790a7b
> ---
> gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index aebbae1521..aecebb1dde 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -14364,6 +14364,42 @@ (define-public python-appdirs
> should be stored on various operating systems.")
> (license license:expat)))
>
> +(define-public python-apprise
> + (package
> + (name "python-apprise")
> + (version "1.7.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "apprise" version))
> + (sha256
> + (base32 "0nkfv0pyn13lqdr3g3r1dhhnqxkjiayf9pny4m254w04al49shwd"))
> + ;; MacOS tests are failing when attempting to mock terminal-notifier calls
> + ;; We don't need to test for MacOS support, and removing this file causes
> + ;; tests to succeed
Please punctuate your comments (including periods).
> + (modules '((guix build utils)))
> + (snippet '(begin
> + (delete-file-recursively "test/test_plugin_macosx.py")))))
> + (build-system pyproject-build-system)
> + (propagated-inputs (list python-certifi
> + python-click
> + python-markdown
> + python-pyyaml
> + python-requests
> + python-requests-oauthlib))
> + (native-inputs (list python-babel
> + python-coverage
> + python-flake8
> + python-pytest
> + python-pytest-cov
> + python-pytest-mock
> + python-pytest-xdist))
Nitpick: I prefer to list inputs in the order of native, inputs,
propagated. Was the above order produced by the pypi importer?
> + (home-page "https://github.com/caronc/apprise")
> + (synopsis "Push Notifications that work with just about every platform!")
This is too verbose for a synopsis. Synopses should describe in a few
words what the package *is*, such as "Push notification library and
utility" (no trailing period here).
> + (description
> + "Push Notifications that work with just about every platform!")
That sounds like marketing talk. Keep it dry and factual, synthesizing
the interesting technical bits from their description text available
from <https://github.com/caronc/apprise>.
> + (license license:bsd-3)))
Github says bsd-2. Could you check?
Other than that, it looks good to me. Could you please send a v2 with the
requested changes?
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-01-21 4:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 14:20 [bug#68569] [PATCH 0/2] gnu: borgmatic: Update to 1.8.6 Mike Delago
2024-01-18 14:32 ` [bug#68569] [PATCH 1/2] gnu: Add python-apprise Mike Delago
2024-01-21 4:57 ` Maxim Cournoyer [this message]
2024-01-18 14:32 ` [bug#68569] [PATCH 2/2] gnu: borgmatic: Update to 1.8.6 Mike Delago
2024-01-21 4:59 ` Maxim Cournoyer
2024-01-21 20:07 ` [bug#68569] [PATCH v2 0/2] " Mike Delago
2024-01-21 20:07 ` [bug#68569] [PATCH v2 1/2] gnu: Add python-apprise Mike Delago
2024-01-21 20:07 ` [bug#68569] [PATCH v2 2/2] gnu: borgmatic: Update to 1.8.6 Mike Delago
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cytvb7x7.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=68569@debbugs.gnu.org \
--cc=michaeldelago98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).